Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754356AbdIZEyT (ORCPT ); Tue, 26 Sep 2017 00:54:19 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33038 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753923AbdIZEyS (ORCPT ); Tue, 26 Sep 2017 00:54:18 -0400 X-Google-Smtp-Source: AOwi7QAhVMs52CYjBS2vo9ofPQFylQDhr/xSx2W4G/m2aU26ksamnMnQZv++Mrs1COsmMEeGKmd9SA== Date: Tue, 26 Sep 2017 06:54:10 +0200 From: Daniel Vetter To: Matthias Kaehlcke Cc: Daniel Vetter , Jani Nikula , David Airlie , Tvrtko Ursulin , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, Nick Desaulniers , dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/i915: Mark wait_for_engine() as maybe_unused Message-ID: <20170926045410.26imjvhwbo4kvjuv@phenom.ffwll.local> Mail-Followup-To: Matthias Kaehlcke , Daniel Vetter , Jani Nikula , David Airlie , Tvrtko Ursulin , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, Nick Desaulniers , dri-devel@lists.freedesktop.org References: <20170825170945.156639-1-mka@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170825170945.156639-1-mka@chromium.org> X-Operating-System: Linux phenom 4.12.0-1-amd64 User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1964 Lines: 56 On Fri, Aug 25, 2017 at 10:09:45AM -0700, Matthias Kaehlcke wrote: > The only call of wait_for_engine() is wrapped in a GEM_WARN_ON macro, > which confusingly suppresses the call unless CONFIG_DRM_I915_DEBUG_GEM > is set. > > According to http://www.spinics.net/lists/intel-gfx/msg128768.html the > current behavior is correct, even though it's not obvious. Different > solutions to improve GEM_WARN_ON were discussed, but no conclusion > was reached. > > Mark wait_for_engine() as maybe_unused to avoid a compiler warning, > according to the above discussion this is still needed evein if > GEM_WARN_ON is eventually refactored. > > Reported-by: Nick Desaulniers > Signed-off-by: Matthias Kaehlcke Seems to be taken care of already in commit cad9946c2a4375386062131858881cfd30fc1b8f Author: Chris Wilson Date: Sat Aug 26 12:09:33 2017 +0100 drm/i915: Always sanity check engine state upon idling Cheers, Daniel > --- > drivers/gpu/drm/i915/i915_gem.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > index 969bac8404f1..52d0b7d0082b 100644 > --- a/drivers/gpu/drm/i915/i915_gem.c > +++ b/drivers/gpu/drm/i915/i915_gem.c > @@ -3364,7 +3364,8 @@ static int wait_for_timeline(struct i915_gem_timeline *tl, unsigned int flags) > return 0; > } > > -static int wait_for_engine(struct intel_engine_cs *engine, int timeout_ms) > +static __maybe_unused int wait_for_engine( > + struct intel_engine_cs *engine, int timeout_ms) > { > return wait_for(intel_engine_is_idle(engine), timeout_ms); > } > -- > 2.14.1.342.g6490525c54-goog > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch