Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936252AbdIZFRg (ORCPT ); Tue, 26 Sep 2017 01:17:36 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:46597 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935700AbdIZFRf (ORCPT ); Tue, 26 Sep 2017 01:17:35 -0400 Subject: Re: [PATCH v3 1/2] watchdog: dw_wdt: add stop watchdog operation To: Guenter Roeck , Oleksij Rempel Cc: Wim Van Sebroeck , Dinh Nguyen , Rob Herring , Mark Rutland , Steffen Trumtrar , linux-watchdog@vger.kernel.org, kernel@pengutronix.de, Russell King , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20170925052531.1692-1-o.rempel@pengutronix.de> <20170925161643.GA32601@roeck-us.net> From: Oleksij Rempel Message-ID: <2203f151-99c8-6c58-8766-70813fafe64d@pengutronix.de> Date: Tue, 26 Sep 2017 07:17:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170925161643.GA32601@roeck-us.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:5972:3060:f674:c7e9 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1549 Lines: 49 Hi, On 25.09.2017 18:16, Guenter Roeck wrote: > On Mon, Sep 25, 2017 at 07:25:30AM +0200, Oleksij Rempel wrote: >> From: Steffen Trumtrar >> >> The only way of stopping the watchdog is by resetting it. >> Add the watchdog op for stopping the device and reset if >> a reset line is provided. >> >> Signed-off-by: Steffen Trumtrar >> Signed-off-by: Oleksij Rempel >> Cc: Wim Van Sebroeck >> Cc: Guenter Roeck >> Cc: linux-watchdog@vger.kernel.org >> --- >> >> changes v3: >> - don't return error if rst is not present and set WDOG_HW_RUNNING bit >> to notify watchdog core. >> >> changes v2: >> - test if dw_wdt->rst is NULL instead of IS_ERR >> >> drivers/watchdog/dw_wdt.c | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c >> index 36be987ff9ef..6cc56b18ee52 100644 >> --- a/drivers/watchdog/dw_wdt.c >> +++ b/drivers/watchdog/dw_wdt.c >> @@ -135,6 +135,21 @@ static int dw_wdt_start(struct watchdog_device *wdd) >> return 0; >> } >> >> +static int dw_wdt_stop(struct watchdog_device *wdd) >> +{ >> + struct dw_wdt *dw_wdt = to_dw_wdt(wdd); >> + >> + if (!dw_wdt->rst) { >> + set_bit(WDOG_HW_RUNNING, &wdd->status); > > Setting WDOG_HW_RUNNING should be dropped from dw_wdt_start(). you mean, this patch is OK, and i need to provide one more which is removing WDOG_HW_RUNNING from dw_wdt_start(). Correct? Regards, Oleksij