Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965724AbdIZGSK (ORCPT <rfc822;w@1wt.eu>);
        Tue, 26 Sep 2017 02:18:10 -0400
Received: from mga03.intel.com ([134.134.136.65]:21943 "EHLO mga03.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S933842AbdIZGSH (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 26 Sep 2017 02:18:07 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,439,1500966000"; 
   d="scan'208";a="1199035944"
From: "Zhang, Rui" <rui.zhang@intel.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
        Rafal Milecki <rafal@milecki.pl>
CC: Markus Mayer <code@mmayer.net>, Eduardo Valentin <edubezval@gmail.com>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        "Doug Berger" <opendmb@gmail.com>,
        Brian Norris <computersforpeace@gmail.com>,
        Gregory Fong <gregory.0xf0@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>, Arnd Bergmann <arnd@arndb.de>,
        Olof Johansson <olof@lixom.net>,
        "Broadcom Kernel List" <bcm-kernel-feedback-list@broadcom.com>,
        Power Management List <linux-pm@vger.kernel.org>,
        Device Tree List <devicetree@vger.kernel.org>,
        ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
        Markus Mayer <mmayer@broadcom.com>
Subject: RE: [PATCH v4 2/4] thermal: add brcmstb AVS TMON driver
Thread-Topic: [PATCH v4 2/4] thermal: add brcmstb AVS TMON driver
Thread-Index: AQHTEVtdcLi0oFWggkymE3kTcXWYXKKEcPMAgAAJeICAAAHRgIA/zkyAgADvaBCAARj7gIAAo07g
Date: Tue, 26 Sep 2017 06:17:54 +0000
Message-ID: <744357E9AAD1214791ACBA4B0B9092636BE1FEEB@SHSMSX101.ccr.corp.intel.com>
References: <20170809220257.4234-1-code@mmayer.net>
 <20170809220257.4234-3-code@mmayer.net> <1502777298.2591.1.camel@intel.com>
 <95da51df3cadbb05f721f2e5b8d59f8d@milecki.pl>
 <1502779721.2591.4.camel@intel.com>
 <4ec0715e-fcd7-3aec-3589-96426575c373@gmail.com>
 <744357E9AAD1214791ACBA4B0B9092636BE1FB55@SHSMSX101.ccr.corp.intel.com>
 <1e23383c-7c63-04fc-0f07-21b0e418e3de@gmail.com>
In-Reply-To: <1e23383c-7c63-04fc-0f07-21b0e418e3de@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id v8Q6Jg2f015510
Content-Length: 4634
Lines: 122

Hi, Florian,

> -----Original Message-----
> From: Florian Fainelli [mailto:f.fainelli@gmail.com]
> Sent: Tuesday, September 26, 2017 12:14 PM
> To: Zhang, Rui <rui.zhang@intel.com>; Rafal Milecki <rafal@milecki.pl>
> Cc: Markus Mayer <code@mmayer.net>; Eduardo Valentin
> <edubezval@gmail.com>; Rob Herring <robh+dt@kernel.org>; Mark Rutland
> <mark.rutland@arm.com>; Doug Berger <opendmb@gmail.com>; Brian
> Norris <computersforpeace@gmail.com>; Gregory Fong
> <gregory.0xf0@gmail.com>; Russell King <linux@armlinux.org.uk>; Catalin
> Marinas <catalin.marinas@arm.com>; Will Deacon <will.deacon@arm.com>;
> Arnd Bergmann <arnd@arndb.de>; Olof Johansson <olof@lixom.net>;
> Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>; Power
> Management List <linux-pm@vger.kernel.org>; Device Tree List
> <devicetree@vger.kernel.org>; ARM Kernel List <linux-arm-
> kernel@lists.infradead.org>; Linux Kernel Mailing List <linux-
> kernel@vger.kernel.org>; Markus Mayer <mmayer@broadcom.com>
> Subject: Re: [PATCH v4 2/4] thermal: add brcmstb AVS TMON driver
> Importance: High
> 
> On 09/25/2017 08:02 PM, Zhang, Rui wrote:
> > Hi, Florian,
> >
> > This patch set was dropped in the last minute because of this
> > discussion https://patchwork.kernel.org/patch/9936325/
> > as I don’t want to rebase the patch before sending the pull request.
> 
> Ah, you wanted to squash that patch into the initial submission?
> 
> >
> > I don’t think we can make it for 4.14.
> > Eduardo will be back and pick the soc patches for 4.15.
> 
> I assume you would want to get that particular patch squashed into a clean
> submission targeting 4.15 now, right?
> 
Yes. As the patch in this thread has not been in upstream yet, I'd prefer the
fix/cleanup meld into the original patch before sending upstream.

Thanks,
Rui

> Thanks
> 
> >
> > Thanks,
> > rui
> >
> >
> >
> > -----Original Message-----
> > From: Florian Fainelli [mailto:f.fainelli@gmail.com]
> > Sent: Monday, September 25, 2017 5:11 AM
> > To: Zhang, Rui <rui.zhang@intel.com>; Rafał Miłecki <rafal@milecki.pl>
> > Cc: Markus Mayer <code@mmayer.net>; Eduardo Valentin
> > <edubezval@gmail.com>; Rob Herring <robh+dt@kernel.org>; Mark
> Rutland
> > <mark.rutland@arm.com>; Doug Berger <opendmb@gmail.com>; Brian
> Norris
> > <computersforpeace@gmail.com>; Gregory Fong
> <gregory.0xf0@gmail.com>;
> > Russell King <linux@armlinux.org.uk>; Catalin Marinas
> > <catalin.marinas@arm.com>; Will Deacon <will.deacon@arm.com>; Arnd
> > Bergmann <arnd@arndb.de>; Olof Johansson <olof@lixom.net>;
> Broadcom
> > Kernel List <bcm-kernel-feedback-list@broadcom.com>; Power
> Management
> > List <linux-pm@vger.kernel.org>; Device Tree List
> > <devicetree@vger.kernel.org>; ARM Kernel List
> > <linux-arm-kernel@lists.infradead.org>; Linux Kernel Mailing List
> > <linux-kernel@vger.kernel.org>; Markus Mayer <mmayer@broadcom.com>
> > Subject: Re: [PATCH v4 2/4] thermal: add brcmstb AVS TMON driver
> > Importance: High
> >
> > Le 08/14/17 à 23:48, Zhang Rui a écrit :
> >> On Tue, 2017-08-15 at 08:42 +0200, Rafał Miłecki wrote:
> >>> On 2017-08-15 08:08, Zhang Rui wrote:
> >>>>
> >>>>>
> >>>>> diff --git a/drivers/thermal/broadcom/Kconfig
> >>>>> b/drivers/thermal/broadcom/Kconfig
> >>>>> index 42c098e..c106a15 100644
> >>>>> --- a/drivers/thermal/broadcom/Kconfig
> >>>>> +++ b/drivers/thermal/broadcom/Kconfig
> >>>>> @@ -6,6 +6,13 @@ config BCM2835_THERMAL
> >>>>>  	help
> >>>>>  	  Support for thermal sensors on Broadcom bcm2835 SoCs.
> >>>>>
> >>>>> +config BRCMSTB_THERMAL
> >>>>> +	tristate "Broadcom STB AVS TMON thermal driver"
> >>>>> +	depends on ARCH_BRCMSTB || COMPILE_TEST
> >>>>> +	help
> >>>>> +	  Enable this driver if you have a Broadcom STB SoC and
> >>>>> would like
> >>>>> +	  thermal framework support.
> >>>>> +
> >>>> I don't understand why I got the following checkpatch warning
> >>>>
> >>>> WARNING: please write a paragraph that describes the config symbol
> >>>> fully
> >>>> #73: FILE: drivers/thermal/broadcom/Kconfig:9:
> >>>> +config BRCMSTB_THERMAL
> >>>>
> >>>> I didn't see this for other Kconfig changes.
> >>> It's because your help message is only 2 lines long (instead of 3).
> >>>
> >>> Some (many?) maintainers aren't pedantic about that, a common sense
> >>> should be applied ;)
> >>
> >> thanks for explaining.
> >> Patch 1 and 2 queued for next merge window.
> >
> > Humm, I don't see this driver in your latest 4.14 pull request to Linus, so
> what happened here exactly? Can we expect this driver to be submitted for
> 4.14 or we just happened to have missed this window now?
> > --
> > Florian
> >
> 
> --
> Florian