Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966032AbdIZGdX (ORCPT ); Tue, 26 Sep 2017 02:33:23 -0400 Received: from regular1.263xmail.com ([211.150.99.133]:44540 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936176AbdIZGdV (ORCPT ); Tue, 26 Sep 2017 02:33:21 -0400 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <3ede02738a663a123021379e7ca57de1> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" To: Thomas Meyer , airlied@linux.ie, heiko@sntech.de, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <1505946334393-568186305-0-diffsplit-thomas@m3y3r.de> <1505946334393-988165015-7-diffsplit-thomas@m3y3r.de> <20170926051241.rwzpxlk4sfju7ctv@phenom.ffwll.local> From: Mark yao Message-ID: Date: Tue, 26 Sep 2017 14:33:07 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170926051241.rwzpxlk4sfju7ctv@phenom.ffwll.local> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1906 Lines: 55 On 2017年09月26日 13:12, Daniel Vetter wrote: > On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote: >> On 2017年09月21日 06:29, Thomas Meyer wrote: >>> Use vma_pages function on vma object instead of explicit computation. >>> Found by coccinelle spatch "api/vma_pages.cocci" >>> >>> Signed-off-by: Thomas Meyer >>> --- >> Looks good for me: >> Acked-by: Mark Yao > Once more a maintainer who acks a patch and doesn't push it. This is > really confusing, who exactly do you expect to handle this patch for you? > > Please push to drm-misc-next (also for future patches), thanks. > -Daniel Hi Daniel I Saw the patch title is "[PATCH 7/7]", I guessed it's one of a series of patches and maybe it can pushed by series. Ok, Pushed it to drm-misc-next. > >>> diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c >>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c >>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c >>> @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_ >>> { >>> struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj); >>> unsigned int i, count = obj->size >> PAGE_SHIFT; >>> - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; >>> + unsigned long user_count = vma_pages(vma); >>> unsigned long uaddr = vma->vm_start; >>> unsigned long offset = vma->vm_pgoff; >>> unsigned long end = user_count + offset; >>> >>> _______________________________________________ >>> Linux-rockchip mailing list >>> Linux-rockchip@lists.infradead.org >>> http://lists.infradead.org/mailman/listinfo/linux-rockchip >>> >>> >>> >> -- >> Ｍark Yao >> >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ｍark Ya