Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966243AbdIZGm3 (ORCPT ); Tue, 26 Sep 2017 02:42:29 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:59429 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966172AbdIZGmQ (ORCPT ); Tue, 26 Sep 2017 02:42:16 -0400 Date: Mon, 25 Sep 2017 23:42:13 -0700 From: Christoph Hellwig To: Linus Torvalds Cc: Al Viro , Kyle Huey , open list , "Robert O'Callahan" Subject: Re: [git pull] vfs.git regression fix Re: Regression related to ipc shmctl compat Message-ID: <20170926064213.GA8473@infradead.org> References: <20170926010036.GX32076@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 702 Lines: 13 On Mon, Sep 25, 2017 at 06:37:28PM -0700, Linus Torvalds wrote: > Pulled and pushed out, but I'd like to note that sparse would have > caught this. Except we are so far away from being sparse-clean that > nobody runs it. I tend to run sparse over the nvme code before sending pull request every time. But it's a fairly new codebase, so it it actually is clean. I wish we'd just default to running sparse at some point so people have to clean their shit up, as it catches a lot of useful things. But maybe for the default we want to tune it down a bit (e.g. don't warn about missing statics by default, skip the lock imbalance checks which while often useful also generate tons of false positives).