Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966666AbdIZHIQ (ORCPT ); Tue, 26 Sep 2017 03:08:16 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:45405 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966420AbdIZHIO (ORCPT ); Tue, 26 Sep 2017 03:08:14 -0400 Date: Tue, 26 Sep 2017 10:07:58 +0300 From: Yuval Shaia To: Arvind Yadav Cc: matanb@mellanox.com, leonro@mellanox.com, dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] IB/mlx5:: pr_err() and mlx5_ib_dbg() strings should end with newlines Message-ID: <20170926070758.GC5825@yuvallap> References: <7a5a195cd37db476a2ca007eddc0f28f3ade265b.1506407876.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7a5a195cd37db476a2ca007eddc0f28f3ade265b.1506407876.git.arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.9.0 (2017-09-02) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1568 Lines: 40 On Tue, Sep 26, 2017 at 12:20:01PM +0530, Arvind Yadav wrote: > pr_err() and mlx5_ib_dbg( messages should terminated with a new-line to > avoid other messages being concatenated. > > Signed-off-by: Arvind Yadav > --- > drivers/infiniband/hw/mlx5/mr.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c > index 0e2789d..92d643a 100644 > --- a/drivers/infiniband/hw/mlx5/mr.c > +++ b/drivers/infiniband/hw/mlx5/mr.c > @@ -1229,13 +1229,13 @@ struct ib_mr *mlx5_ib_reg_user_mr(struct ib_pd *pd, u64 start, u64 length, > mr = alloc_mr_from_cache(pd, umem, virt_addr, length, ncont, > page_shift, order, access_flags); > if (PTR_ERR(mr) == -EAGAIN) { > - mlx5_ib_dbg(dev, "cache empty for order %d", order); > + mlx5_ib_dbg(dev, "cache empty for order %d\n", order); > mr = NULL; > } > } else if (!MLX5_CAP_GEN(dev->mdev, umr_extended_translation_offset)) { > if (access_flags & IB_ACCESS_ON_DEMAND) { > err = -EINVAL; > - pr_err("Got MR registration for ODP MR > 512MB, not supported for Connect-IB"); > + pr_err("Got MR registration for ODP MR > 512MB, not supported for Connect-IB\n"); > goto error; > } > use_umr = false; > -- > 1.9.1 FWIW, Reviewed-by: Yuval Shaia > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html