Date: Tue, 26 Sep 2017 10:19:21 +0300
From: Yuval Shaia <yuval.shaia@oracle.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: selvin.xavier@broadcom.com, dledford@redhat.com, sean.hefty@intel.com,
        hal.rosenstock@gmail.com, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IB/ocrdma: pr_err() strings should end with newlines
Message-ID: <20170926071920.GD5825@yuvallap>
References: <28298577a7f6111b2d40780dddd3c87a32168ab7.1506408446.git.arvind.yadav.cs@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <28298577a7f6111b2d40780dddd3c87a32168ab7.1506408446.git.arvind.yadav.cs@gmail.com>
User-Agent: Mutt/1.9.0 (2017-09-02)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1214
Lines: 34

On Tue, Sep 26, 2017 at 12:21:44PM +0530, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/infiniband/hw/ocrdma/ocrdma_stats.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
> index 66056f9..e528d7a 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
> @@ -658,7 +658,7 @@ static ssize_t ocrdma_dbgfs_ops_write(struct file *filp,
>  		if (reset) {
>  			status = ocrdma_mbx_rdma_stats(dev, true);
>  			if (status) {
> -				pr_err("Failed to reset stats = %d", status);
> +				pr_err("Failed to reset stats = %d\n", status);
>  				goto err;
>  			}
>  		}

While there, can you also fix line 1096 in ocrdma_hw.c?

(is it too naive to expect checkptahc to catch such errors?)

> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html