Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967217AbdIZHZF (ORCPT ); Tue, 26 Sep 2017 03:25:05 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:5712 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S967185AbdIZHZA (ORCPT ); Tue, 26 Sep 2017 03:25:00 -0400 X-UUID: e3e846c1b12444cb80e55a286de12377-20170926 Message-ID: <1506410696.21515.17.camel@mtkswgap22> Subject: Re: [PATCH] soc: mediatek: place Kconfig for all SoC driver under menu From: Sean Wang To: Jean Delvare CC: , , , , Date: Tue, 26 Sep 2017 15:24:56 +0800 In-Reply-To: <20170926075558.7e4c99c3@endymion> References: <20170926075558.7e4c99c3@endymion> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1970 Lines: 69 On Tue, 2017-09-26 at 07:55 +0200, Jean Delvare wrote: > On Thu, 21 Sep 2017 16:46:35 +0800, sean.wang@mediatek.com wrote: > > From: Sean Wang > > > > Add cleanup for placing all Kconfig for all MediaTek SoC drivers under > > the independent menu as other SoCs vendor usually did. > > > > Signed-off-by: Sean Wang > > --- > > drivers/soc/mediatek/Kconfig | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig > > index 609bb34..a2fcd7f 100644 > > --- a/drivers/soc/mediatek/Kconfig > > +++ b/drivers/soc/mediatek/Kconfig > > @@ -1,6 +1,8 @@ > > # > > # MediaTek SoC drivers > > # > > +menu "MediaTek SoC drivers" > > Could it depend on ARCH_MEDIATEK || COMPILE_TEST? So that it isn't > presented if it is going to be empty. > Okay, I'll add a dependency for the menu. And all "depends on ARCH_MEDIATEK" for items insides the menu can also be removed. such as menu "MediaTek SoC drivers" + depends on ARCH_MEDIATEK || COMPILE_TEST config MTK_INFRACFG bool "MediaTek INFRACFG Support" - depends on ARCH_MEDIATEK || COMPILE_TEST select REGMAP help Say yes here to add support for the MediaTek INFRACFG controller. The @@ -14,7 +14,6 @@ config MTK_INFRACFG config MTK_PMIC_WRAP tristate "MediaTek PMIC Wrapper Support" - depends on ARCH_MEDIATEK select RESET_CONTROLLER select REGMAP help @@ -24,7 +23,6 @@ config MTK_PMIC_WRAP config MTK_SCPSYS bool "MediaTek SCPSYS Support" - depends on ARCH_MEDIATEK || COMPILE_TEST default ARCH_MEDIATEK > > + > > config MTK_INFRACFG > > bool "MediaTek INFRACFG Support" > > depends on ARCH_MEDIATEK || COMPILE_TEST > > @@ -30,3 +32,5 @@ config MTK_SCPSYS > > help > > Say yes here to add support for the MediaTek SCPSYS power domain > > driver. > > + > > +endmenu > >