Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936845AbdIZH1H (ORCPT ); Tue, 26 Sep 2017 03:27:07 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:60826 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936812AbdIZH0y (ORCPT ); Tue, 26 Sep 2017 03:26:54 -0400 X-Google-Smtp-Source: AOwi7QAfPw7oNlLjhfcerwPjEkk34VOzxX48QyOqaiVnHD59YnbHFAUWUGxFsRroXIXsXocbZ/57EmPHNAUkTLylDYg= MIME-Version: 1.0 In-Reply-To: <20170926064456.GA28611@infradead.org> References: <1506408099-18488-1-git-send-email-acelan.kao@canonical.com> <1506408099-18488-2-git-send-email-acelan.kao@canonical.com> <20170926064456.GA28611@infradead.org> From: AceLan Kao Date: Tue, 26 Sep 2017 15:26:51 +0800 Message-ID: Subject: Re: [PATCH 2/6] ath9k: add a quirk to set use_msi automatically To: Christoph Hellwig Cc: QCA ath9k Development , Kalle Valo , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, "Linux-Kernel@Vger. Kernel. Org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 705 Lines: 15 Ath9k is an old driver for old chips, and they work fine with legacy INTx. But some new platforms are using it, so I think we should list those new platforms which blocks INTx in the driver. BTW, new chips use ath10k driver. 2017-09-26 14:44 GMT+08:00 Christoph Hellwig : > On Tue, Sep 26, 2017 at 02:41:35PM +0800, AceLan Kao wrote: >> Some platform(BIOS) blocks legacy interrupts (INTx), and only allows MSI >> for WLAN device. So adding a quirk to list those machines and set >> use_msi automatically. >> Adding Dell Inspiron 24-3460 to the quirk. > > Huh? Using MSI should be the default, and skipping MSI should be > a quirk if needed at all (usually it should be autodetected)