Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967511AbdIZHch (ORCPT ); Tue, 26 Sep 2017 03:32:37 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:36153 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966729AbdIZHcf (ORCPT ); Tue, 26 Sep 2017 03:32:35 -0400 X-Google-Smtp-Source: AOwi7QAvpPnqQ6qydoCzlNHmEuHbz3TLolqjERNJPxFf+2ysuL9OYw8n7veg86FpDr9/4JSdGN/VGg== Subject: Re: [PATCH] IB/ocrdma: pr_err() strings should end with newlines To: Yuval Shaia References: <28298577a7f6111b2d40780dddd3c87a32168ab7.1506408446.git.arvind.yadav.cs@gmail.com> <20170926071920.GD5825@yuvallap> Cc: selvin.xavier@broadcom.com, dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org From: Arvind Yadav Message-ID: Date: Tue, 26 Sep 2017 13:01:33 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170926071920.GD5825@yuvallap> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1382 Lines: 39 Hi Yuval, On Tuesday 26 September 2017 12:49 PM, Yuval Shaia wrote: > On Tue, Sep 26, 2017 at 12:21:44PM +0530, Arvind Yadav wrote: >> pr_err() messages should end with a new-line to avoid other messages >> being concatenated. >> >> Signed-off-by: Arvind Yadav >> --- >> drivers/infiniband/hw/ocrdma/ocrdma_stats.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c >> index 66056f9..e528d7a 100644 >> --- a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c >> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c >> @@ -658,7 +658,7 @@ static ssize_t ocrdma_dbgfs_ops_write(struct file *filp, >> if (reset) { >> status = ocrdma_mbx_rdma_stats(dev, true); >> if (status) { >> - pr_err("Failed to reset stats = %d", status); >> + pr_err("Failed to reset stats = %d\n", status); >> goto err; >> } >> } > While there, can you also fix line 1096 in ocrdma_hw.c? > > (is it too naive to expect checkptahc to catch such errors?) As per your suggestion, I have done the changes. > >> -- >> 1.9.1 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html ~arvind