Date: Tue, 26 Sep 2017 11:38:43 +0300
From: Leon Romanovsky <leonro@mellanox.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: matanb@mellanox.com, dledford@redhat.com, sean.hefty@intel.com,
        hal.rosenstock@gmail.com, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IB/mlx5:: pr_err() and mlx5_ib_dbg() strings should end
 with newlines
Message-ID: <20170926083843.GB6816@mtr-leonro.local>
References: <7a5a195cd37db476a2ca007eddc0f28f3ade265b.1506407876.git.arvind.yadav.cs@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="61jdw2sOBCFtR2d/"
Content-Disposition: inline
In-Reply-To: <7a5a195cd37db476a2ca007eddc0f28f3ade265b.1506407876.git.arvind.yadav.cs@gmail.com>
User-Agent: Mutt/1.9.0 (2017-09-02)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2017 08:38:48.8202
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB1934
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2474
Lines: 65


--61jdw2sOBCFtR2d/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Sep 26, 2017 at 12:20:01PM +0530, Arvind Yadav wrote:
> pr_err() and mlx5_ib_dbg( messages should terminated with a new-line to
> avoid other messages being concatenated.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/infiniband/hw/mlx5/mr.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Did you see it is happening?
It is not needed after 4bcc595ccd80 ("printk: reinstate KERN_CONT for printing continuation lines")

Thanks.

>
> diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c
> index 0e2789d..92d643a 100644
> --- a/drivers/infiniband/hw/mlx5/mr.c
> +++ b/drivers/infiniband/hw/mlx5/mr.c
> @@ -1229,13 +1229,13 @@ struct ib_mr *mlx5_ib_reg_user_mr(struct ib_pd *pd, u64 start, u64 length,
>  		mr = alloc_mr_from_cache(pd, umem, virt_addr, length, ncont,
>  					 page_shift, order, access_flags);
>  		if (PTR_ERR(mr) == -EAGAIN) {
> -			mlx5_ib_dbg(dev, "cache empty for order %d", order);
> +			mlx5_ib_dbg(dev, "cache empty for order %d\n", order);
>  			mr = NULL;
>  		}
>  	} else if (!MLX5_CAP_GEN(dev->mdev, umr_extended_translation_offset)) {
>  		if (access_flags & IB_ACCESS_ON_DEMAND) {
>  			err = -EINVAL;
> -			pr_err("Got MR registration for ODP MR > 512MB, not supported for Connect-IB");
> +			pr_err("Got MR registration for ODP MR > 512MB, not supported for Connect-IB\n");
>  			goto error;
>  		}
>  		use_umr = false;
> --
> 1.9.1
>

--61jdw2sOBCFtR2d/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAlnKEhIACgkQ5GN7iDZy
WKfN9w//Z2I3YrmqWGw/HrmiaEWZ2xRY4SSLf1LpX6IJlFNd/1+10LDmZwnTKxnU
Su4h9ssmiO4RZ7g9Y1IxQrcOzAbj7xXGJgDI7qaS9otYsJCIZXB1lggUVIYf1uAe
NBp2x8kX8T+/fN0VjZsPBA4vbWwSspkOdwkNCsni05fYZgLILKbW7SvzATX3IjEN
XcZYatDEMGMSDgdZYuzHOqky7gE92oS3x6WiFvL1gyKqq8JkuFYc66s+LGkU5JNe
KdRsL6k3V8gC3xKtffOx0RbGK2WGHVYBt7o/SEcTwayp0IN4Psult1P8cxNZyUdV
n29JmDBYANn1ENo1Gjrfr3jVw4AqLW/Bdu+1XketgJVVU8HZj5MEzTrRhEvOBRSD
H8c6jztOkdJYwBwK3hag+vG5/VViD9NQ0O3kX1UQKnsuziCCJLlyXBbOc4r1m79v
xSeDu9ER6+c7pyJOq5RsG1lZAvkrx9pPX4/A9VWr8cffhhigq1u8Vv+86OEIoNsl
nLTk0n9k5UlW4sPdYW5ZsClMWDORAxpLYaCCPfdKuPeg7iHiUbW6oPEH8n+WHp6V
yb7mOwsbklZjpGA8MpNjHTqObLDdgjbmfGSY9ye2t1GovtU0CY8xk2EEWv0mqb0b
BNMEICN9y+a72FkBkPkwr+f22Wx1mQdt1nvuP4nYwHtWa6GmmBY=
=9aF0
-----END PGP SIGNATURE-----

--61jdw2sOBCFtR2d/--