Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937105AbdIZKEr (ORCPT ); Tue, 26 Sep 2017 06:04:47 -0400 Received: from mail-ua0-f193.google.com ([209.85.217.193]:37184 "EHLO mail-ua0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934122AbdIZKEp (ORCPT ); Tue, 26 Sep 2017 06:04:45 -0400 X-Google-Smtp-Source: AOwi7QDsrVNlsWrxO0a9Nl2xwsMmeEMN74K3U0kZ11/nv//Vw81LSMoVAP55sBYl9IqTJWQk3cGKW3Cd62iTJRUSLZM= MIME-Version: 1.0 In-Reply-To: <20170926095127.p5ocg44et2g62gku@techsingularity.net> References: <1506415604-4310-1-git-send-email-zhuhui@xiaomi.com> <20170926095127.p5ocg44et2g62gku@techsingularity.net> From: Hui Zhu Date: Tue, 26 Sep 2017 18:04:04 +0800 Message-ID: Subject: Re: [RFC 0/2] Use HighAtomic against long-term fragmentation To: Mel Gorman Cc: Hui Zhu , Andrew Morton , Michal Hocko , Vlastimil Babka , hillf.zj@alibaba-inc.com, Linux Memory Management List , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1319 Lines: 32 2017-09-26 17:51 GMT+08:00 Mel Gorman : > On Tue, Sep 26, 2017 at 04:46:42PM +0800, Hui Zhu wrote: >> Current HighAtomic just to handle the high atomic page alloc. >> But I found that use it handle the normal unmovable continuous page >> alloc will help to against long-term fragmentation. >> > > This is not wise. High-order atomic allocations do not always have a > smooth recovery path such as network drivers with large MTUs that have no > choice but to drop the traffic and hope for a retransmit. That's why they > have the highatomic reserve. If the reserve is used for normal unmovable > allocations then allocation requests that could have waited for reclaim > may cause high-order atomic allocations to fail. Changing it may allow > improve latencies in some limited cases while causing functional failures > in others. If there is a special case where there are a large number of > other high-order allocations then I would suggest increasing min_free_kbytes > instead as a workaround. I think let 0 order unmovable page alloc and other order unmovable pages alloc use different migrate types will help against long-term fragmentation. Do you think kernel can add a special migrate type for big than 0 order unmovable pages alloc? Thanks, Hui > > -- > Mel Gorman > SUSE Labs