Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967998AbdIZKRY (ORCPT ); Tue, 26 Sep 2017 06:17:24 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:16827 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S965430AbdIZKRW (ORCPT ); Tue, 26 Sep 2017 06:17:22 -0400 X-UUID: 6df5dcfc068548d0856a5cfcb45bb222-20170926 Message-ID: <1506421025.5626.6.camel@mtksdaap41> Subject: Re: [PATCH v2 05/10] arm: dts: mt7623: update pio, usb and crypto nodes From: Yingjoe Chen To: Ryder Lee CC: Matthias Brugger , , Erin Lo , , , Date: Tue, 26 Sep 2017 18:17:05 +0800 In-Reply-To: <93734b87262a8305b67e989777dfa1297d66cee4.1506390597.git.ryder.lee@mediatek.com> References: <93734b87262a8305b67e989777dfa1297d66cee4.1506390597.git.ryder.lee@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1430 Lines: 48 On Tue, 2017-09-26 at 10:02 +0800, Ryder Lee wrote: > This patch updates pio, usb and crypto nodes to make them be consistent > with the binding documents. > > Signed-off-by: Ryder Lee > --- > arch/arm/boot/dts/mt7623.dtsi | 52 ++++++++++++++++++++++--------------------- > 1 file changed, 27 insertions(+), 25 deletions(-) > > diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi > index 381843e..9ec3767 100644 > --- a/arch/arm/boot/dts/mt7623.dtsi > +++ b/arch/arm/boot/dts/mt7623.dtsi > @@ -226,21 +226,6 @@ > #reset-cells = <1>; > }; > > - pio: pinctrl@10005000 { > - compatible = "mediatek,mt7623-pinctrl", > - "mediatek,mt2701-pinctrl"; > - reg = <0 0x1000b000 0 0x1000>; > - mediatek,pctl-regmap = <&syscfg_pctl_a>; > - pins-are-numbered; > - gpio-controller; > - #gpio-cells = <2>; > - interrupt-controller; > - interrupt-parent = <&gic>; > - #interrupt-cells = <2>; > - interrupts = , > - ; > - }; > - > syscfg_pctl_a: syscfg@10005000 { > compatible = "mediatek,mt7623-pctl-a-syscfg", "syscon"; > reg = <0 0x10005000 0 0x1000>; Hi Ryder, pio node is special, it have 2 registers space. The address 10005000 is for PIO, it was accesed through syscfg_pctl_a regmap. The other one, 0x1000b000, is for EINT. So,I think using address @10005000 is correct. Joe.C