Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030234AbdIZLMS (ORCPT ); Tue, 26 Sep 2017 07:12:18 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:36564 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S967161AbdIZLMR (ORCPT ); Tue, 26 Sep 2017 07:12:17 -0400 Date: Tue, 26 Sep 2017 16:42:11 +0530 From: Gautham R Shenoy To: Kees Cook Cc: Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 03/31] timer: Remove init_timer_pinned_deferrable() in favor of setup_pinned_deferrable_timer() Reply-To: ego@linux.vnet.ibm.com References: <1505950075-50223-1-git-send-email-keescook@chromium.org> <1505950075-50223-4-git-send-email-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1505950075-50223-4-git-send-email-keescook@chromium.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-GCONF: 00 x-cbid: 17092611-0040-0000-0000-000003A8560F X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007795; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000231; SDB=6.00922591; UDB=6.00463727; IPR=6.00702732; BA=6.00005607; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017279; XFM=3.00000015; UTC=2017-09-26 11:12:15 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17092611-0041-0000-0000-0000079D5F49 Message-Id: <20170926111211.GC25906@in.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-09-26_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1709260165 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1849 Lines: 46 On Wed, Sep 20, 2017 at 04:27:27PM -0700, Kees Cook wrote: > Remove uses of init_timer_pinned_deferrable() with open-coded > function and data assignments that could be expressed using > setup_pinned_deferrable_timer(). > > Signed-off-by: Kees Cook Reviewed-by: Gautham R. Shenoy > --- > drivers/cpufreq/powernv-cpufreq.c | 5 ++--- > include/linux/timer.h | 2 -- > 2 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c > index 3ff5160451b4..3946660b0987 100644 > --- a/drivers/cpufreq/powernv-cpufreq.c > +++ b/drivers/cpufreq/powernv-cpufreq.c > @@ -800,9 +800,8 @@ static int powernv_cpufreq_cpu_init(struct cpufreq_policy *policy) > policy->driver_data = gpstates; > > /* initialize timer */ > - init_timer_pinned_deferrable(&gpstates->timer); > - gpstates->timer.data = (unsigned long)policy; > - gpstates->timer.function = gpstate_timer_handler; > + setup_pinned_deferrable_timer(&gpstates->timer, gpstate_timer_handler, > + (unsigned long)policy); > gpstates->timer.expires = jiffies + > msecs_to_jiffies(GPSTATE_TIMER_INTERVAL); > spin_lock_init(&gpstates->gpstate_lock); > diff --git a/include/linux/timer.h b/include/linux/timer.h > index e6789b8757d5..1b2bb2d978de 100644 > --- a/include/linux/timer.h > +++ b/include/linux/timer.h > @@ -132,8 +132,6 @@ static inline void init_timer_on_stack_key(struct timer_list *timer, > __init_timer((timer), TIMER_PINNED) > #define init_timer_deferrable(timer) \ > __init_timer((timer), TIMER_DEFERRABLE) > -#define init_timer_pinned_deferrable(timer) \ > - __init_timer((timer), TIMER_DEFERRABLE | TIMER_PINNED) > #define init_timer_on_stack(timer) \ > __init_timer_on_stack((timer), 0) > > -- > 2.7.4 >