Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937185AbdIZL5U (ORCPT ); Tue, 26 Sep 2017 07:57:20 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:32992 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936361AbdIZL5S (ORCPT ); Tue, 26 Sep 2017 07:57:18 -0400 Subject: Re: [PATCH 2/7] arm64: Cocci spatch "vma_pages" To: Thomas Meyer , catalin.marinas@arm.com, will.deacon@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1505946334393-568186305-0-diffsplit-thomas@m3y3r.de> <1505946334393-397244072-2-diffsplit-thomas@m3y3r.de> From: Robin Murphy Message-ID: <8d4fa6de-f8e2-f073-cfc8-ce78947ad599@arm.com> Date: Tue, 26 Sep 2017 12:57:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1505946334393-397244072-2-diffsplit-thomas@m3y3r.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1053 Lines: 32 On 20/09/17 23:29, Thomas Meyer wrote: > Use vma_pages function on vma object instead of explicit computation. > Found by coccinelle spatch "api/vma_pages.cocci" Reviewed-by: Robin Murphy I guess this can be picked up independently of the other patches? Robin. > Signed-off-by: Thomas Meyer > --- > > diff -u -p a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c > --- a/arch/arm64/mm/dma-mapping.c > +++ b/arch/arm64/mm/dma-mapping.c > @@ -303,8 +303,7 @@ static int __swiotlb_mmap_pfn(struct vm_ > unsigned long pfn, size_t size) > { > int ret = -ENXIO; > - unsigned long nr_vma_pages = (vma->vm_end - vma->vm_start) >> > - PAGE_SHIFT; > + unsigned long nr_vma_pages = vma_pages(vma); > unsigned long nr_pages = PAGE_ALIGN(size) >> PAGE_SHIFT; > unsigned long off = vma->vm_pgoff; > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >