Message-ID: <3F0EC5EF.7090002@sktc.net>
Date: Fri, 11 Jul 2003 09:13:03 -0500
From: "David D. Hagood" <wowbagger@sktc.net>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4b) Gecko/20030507
MIME-Version: 1.0
To: hzhong@cisco.com
CC: "'Alan Stern'" <stern@rowland.harvard.edu>, linux-kernel@vger.kernel.org
Subject: Re: Style question: Should one check for NULL pointers?
References: <01c701c34766$4706cc50$743147ab@amer.cisco.com>
In-Reply-To: <01c701c34766$4706cc50$743147ab@amer.cisco.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1085
Lines: 31

Hua Zhong wrote:

> Not always true. In some cases you know how to handle: just return
> without doing anyting.

That is NOT an error condition - the API specifically allows NULL to be 
passed in, and specifically states that no action will be taken in that 
case.

But consider the following code:

sscanf(0,0);


That IS an error condition - both the string to scan and the format 
string are NULL. In this case sscanf should return EITHER 0 (no items 
matched) or better still -1 (error).

As others have said - ideally, if you have any doubt about a new 
function you are writing being able to succeed, you should write it to 
return a success report.

However, my whole point was that simply checking for null and doing 
nothing when null was not a valid value was violating the rule of "don't 
check if you don't know how to handle".

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/