Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030767AbdIZN0t (ORCPT ); Tue, 26 Sep 2017 09:26:49 -0400 Received: from mail-vk0-f67.google.com ([209.85.213.67]:35420 "EHLO mail-vk0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934627AbdIZN0r (ORCPT ); Tue, 26 Sep 2017 09:26:47 -0400 X-Google-Smtp-Source: AOwi7QCTpnPSnDFYhKNR2BSZBQqn7HEPTSC/qWWkKc5nsjWRizjVJ1TZIUt/d1mQUhsR0zLh6zPF6s27e6U/VH6WE/w= MIME-Version: 1.0 In-Reply-To: References: <20170908183558.1537-3-malat@debian.org> <20170915191837.27564-1-malat@debian.org> From: Mathieu Malaterre Date: Tue, 26 Sep 2017 15:26:26 +0200 X-Google-Sender-Auth: kCrPWOOkhlUH3AXTZtnBTPX5Ei0 Message-ID: Subject: Re: [PATCH v2 3/5] MIPS: jz4780: DTS: Probe the jz4740-watchdog driver from devicetree To: PrasannaKumar Muralidharan Cc: Rob Herring , Mark Rutland , Ralf Baechle , Linus Walleij , Paul Cercueil , devicetree@vger.kernel.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2035 Lines: 64 Hi PrasannaKumar ! On Tue, Sep 26, 2017 at 3:17 PM, PrasannaKumar Muralidharan wrote: > Hi Mathieu, > > On 16 September 2017 at 00:48, Mathieu Malaterre wrote: >> The jz4740-watchdog driver supports both jz4740 & jz4780. >> >> Signed-off-by: Mathieu Malaterre >> --- >> Changes in v2: >> * make the node name generic (Paul Cercueil) >> >> arch/mips/boot/dts/ingenic/jz4780.dtsi | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi >> index 20e37d2d6008..76055bbc823a 100644 >> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi >> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi >> @@ -263,6 +263,11 @@ >> status = "disabled"; >> }; >> >> + watchdog: watchdog@10002000 { >> + compatible = "ingenic,jz4780-watchdog"; > > In drivers/watchdog/jz4740_wdt.c the compatible is declared as > "ingenic,jz4740-watchdog" while your change says > "ingenic,jz4780-watchdog". Can you modify that? Well in the full changeset, you'll find: [PATCH v2 4/5] watchdog: jz4740: Add support for the watchdog in jz4780 SoC https://lkml.org/lkml/2017/9/15/451 There has been some misunderstanding. I still believe I need a new compatible string, even if currently the code is 100% identical. >> + reg = <0x10002000 0x100>; >> + }; >> + > > The structures jz4740_wdt_device and jz4740_wdt_resources can be > removed form arch/mips/jz4740/platform.c as watchdog is declared in > device tree. For JZ4740 platform watchdog is not used so the variables > can be removed. > > Do you mind adding watchdog entry to JZ4740 device tree? Currently > watchdog is not enabled for JZ4740 platform. Will do once this series has been accepted. Thanks for the review ! >> nemc: nemc@13410000 { >> compatible = "ingenic,jz4780-nemc"; >> reg = <0x13410000 0x10000>; >> -- >> 2.11.0 >> > > Regards, > PrasannaKumar