Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969369AbdIZOPC (ORCPT ); Tue, 26 Sep 2017 10:15:02 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34486 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S969344AbdIZOO7 (ORCPT ); Tue, 26 Sep 2017 10:14:59 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C4B4860234 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Christoph Hellwig Cc: AceLan Kao , QCA ath9k Development , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, "Linux-Kernel\@Vger. Kernel. Org" , Daniel Drake Subject: Re: [PATCH 2/6] ath9k: add a quirk to set use_msi automatically References: <1506408099-18488-1-git-send-email-acelan.kao@canonical.com> <1506408099-18488-2-git-send-email-acelan.kao@canonical.com> <20170926064456.GA28611@infradead.org> <20170926140413.GA19977@infradead.org> Date: Tue, 26 Sep 2017 17:14:53 +0300 In-Reply-To: <20170926140413.GA19977@infradead.org> (Christoph Hellwig's message of "Tue, 26 Sep 2017 07:04:13 -0700") Message-ID: <878th14kde.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 617 Lines: 16 Christoph Hellwig writes: > On Tue, Sep 26, 2017 at 03:26:51PM +0800, AceLan Kao wrote: >> Ath9k is an old driver for old chips, and they work fine with legacy INTx. >> But some new platforms are using it, so I think we should list those >> new platforms which blocks INTx in the driver. > > And unless they are broken and need a quirk they should work even better > with MSI if the device advertises MSI support in the PCI capabilities. Daniel Drake (CCed) already found problems with the MSI implementation: https://lkml.kernel.org/r/20170925041153.26574-1-drake@endlessm.com -- Kalle Valo