Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968687AbdIZQK2 (ORCPT ); Tue, 26 Sep 2017 12:10:28 -0400 Received: from mail-yw0-f195.google.com ([209.85.161.195]:38661 "EHLO mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935993AbdIZQK1 (ORCPT ); Tue, 26 Sep 2017 12:10:27 -0400 X-Google-Smtp-Source: AOwi7QBGyPp18M+vbuKIYL24ELmoNoV4mm9T7JwMAJcKChmra64X/6fUeuQsyRncPuOgiQdG2goKoc0M5NwMiBniraE= MIME-Version: 1.0 In-Reply-To: <1505975570447-1553434828-1-diffsplit-thomas@m3y3r.de> References: <1505975570447-826702259-0-diffsplit-thomas@m3y3r.de> <1505975570447-1553434828-1-diffsplit-thomas@m3y3r.de> From: Alex Deucher Date: Tue, 26 Sep 2017 12:10:26 -0400 Message-ID: Subject: Re: [PATCH 1/4] drm/amd/powerplay: Cocci spatch "alloc_cast" To: Thomas Meyer Cc: "Deucher, Alexander" , Christian Koenig , Dave Airlie , amd-gfx list , Maling list - DRI developers , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3870 Lines: 94 On Thu, Sep 21, 2017 at 2:33 AM, Thomas Meyer wrote: > Remove casting the values returned by memory allocation functions like > kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc." > Found by coccinelle spatch "api/alloc/alloc_cast.cocci" > > Signed-off-by: Thomas Meyer > --- > > diff -u -p a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c > --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c > +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c > @@ -291,7 +291,7 @@ static int get_mm_clock_voltage_table( > table_size = sizeof(uint32_t) + > sizeof(phm_ppt_v1_mm_clock_voltage_dependency_record) * > mm_dependency_table->ucNumEntries; > - mm_table = (phm_ppt_v1_mm_clock_voltage_dependency_table *) > + mm_table = > kzalloc(table_size, GFP_KERNEL); Please fix up the whitespace. E.g., mm_table = kzalloc(table_size, GFP_KERNEL); Alex > > if (!mm_table) > @@ -519,7 +519,7 @@ static int get_socclk_voltage_dependency > sizeof(phm_ppt_v1_clock_voltage_dependency_record) * > clk_dep_table->ucNumEntries; > > - clk_table = (phm_ppt_v1_clock_voltage_dependency_table *) > + clk_table = > kzalloc(table_size, GFP_KERNEL); > > if (!clk_table) > @@ -554,7 +554,7 @@ static int get_mclk_voltage_dependency_t > sizeof(phm_ppt_v1_clock_voltage_dependency_record) * > mclk_dep_table->ucNumEntries; > > - mclk_table = (phm_ppt_v1_clock_voltage_dependency_table *) > + mclk_table = > kzalloc(table_size, GFP_KERNEL); > > if (!mclk_table) > @@ -596,7 +596,7 @@ static int get_gfxclk_voltage_dependency > sizeof(phm_ppt_v1_clock_voltage_dependency_record) * > clk_dep_table->ucNumEntries; > > - clk_table = (struct phm_ppt_v1_clock_voltage_dependency_table *) > + clk_table = > kzalloc(table_size, GFP_KERNEL); > > if (!clk_table) > @@ -663,7 +663,7 @@ static int get_pix_clk_voltage_dependenc > sizeof(phm_ppt_v1_clock_voltage_dependency_record) * > clk_dep_table->ucNumEntries; > > - clk_table = (struct phm_ppt_v1_clock_voltage_dependency_table *) > + clk_table = > kzalloc(table_size, GFP_KERNEL); > > if (!clk_table) > @@ -728,7 +728,7 @@ static int get_dcefclk_voltage_dependenc > sizeof(phm_ppt_v1_clock_voltage_dependency_record) * > num_entries; > > - clk_table = (struct phm_ppt_v1_clock_voltage_dependency_table *) > + clk_table = > kzalloc(table_size, GFP_KERNEL); > > if (!clk_table) > @@ -772,7 +772,7 @@ static int get_pcie_table(struct pp_hwmg > sizeof(struct phm_ppt_v1_pcie_record) * > atom_pcie_table->ucNumEntries; > > - pcie_table = (struct phm_ppt_v1_pcie_table *) > + pcie_table = > kzalloc(table_size, GFP_KERNEL); > > if (!pcie_table) > @@ -1026,7 +1026,7 @@ static int get_vddc_lookup_table( > table_size = sizeof(uint32_t) + > sizeof(phm_ppt_v1_voltage_lookup_record) * max_levels; > > - table = (phm_ppt_v1_voltage_lookup_table *) > + table = > kzalloc(table_size, GFP_KERNEL); > > if (NULL == table) > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel