Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969201AbdIZQxn (ORCPT ); Tue, 26 Sep 2017 12:53:43 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:38667 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968396AbdIZQxj (ORCPT ); Tue, 26 Sep 2017 12:53:39 -0400 X-Google-Smtp-Source: AOwi7QCEy1isAOUQl9MtqOyDWk8f9VLxoO3GVySC74Qzb0oH5XjLefzX4HIdlZyjQNbSyqF7QSSvvQ== From: Christian Lamparter To: Andrey Konovalov Cc: Kalle Valo , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Vyukov , Kostya Serebryany Subject: Re: [PATCH v2] p54: don't unregister leds when they are not initialized Date: Tue, 26 Sep 2017 18:53:36 +0200 Message-ID: <1968721.UFOTox51jp@debian64> User-Agent: KMail/5.2.3 (Linux/4.14.0-rc1-wt+; KDE/5.37.0; x86_64; ; ) In-Reply-To: <17c60ebcc8ce7f20de41a55087d24dfdfca09c67.1506438620.git.andreyknvl@google.com> References: <17c60ebcc8ce7f20de41a55087d24dfdfca09c67.1506438620.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 762 Lines: 19 On Tuesday, September 26, 2017 5:11:33 PM CEST Andrey Konovalov wrote: > ieee80211_register_hw() in p54_register_common() may fail and leds won't > get initialized. Currently p54_unregister_common() doesn't check that and > always calls p54_unregister_leds(). The fix is to check priv->registered > flag before calling p54_unregister_leds(). > > Found by syzkaller. > > [...] > process_scheduled_works kernel/workqueue.c:2179 > worker_thread+0xb2b/0x1850 kernel/workqueue.c:2255 > kthread+0x3a1/0x470 kernel/kthread.c:231 > ret_from_fork+0x2a/0x40 arch/x86/entry/entry_64.S:431 > > Signed-off-by: Andrey Konovalov Cc: stable@vger.kernel.org Acked-by: Christian Lamparter Thanks for making the patch too!