Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031560AbdIZSdn (ORCPT ); Tue, 26 Sep 2017 14:33:43 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:34314 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031149AbdIZSdl (ORCPT ); Tue, 26 Sep 2017 14:33:41 -0400 Date: Tue, 26 Sep 2017 11:33:40 -0700 (PDT) Message-Id: <20170926.113340.239908321617902101.davem@davemloft.net> To: himanshujha199640@gmail.com Cc: f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, arnd@arndb.de, yamada.masahiro@socionext.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: bcm63xx_enet: Use setup_timer and mod_timer From: David Miller In-Reply-To: <1506255084-10943-1-git-send-email-himanshujha199640@gmail.com> References: <1506255084-10943-1-git-send-email-himanshujha199640@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 26 Sep 2017 11:33:41 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 512 Lines: 23 From: Himanshu Jha Date: Sun, 24 Sep 2017 17:41:24 +0530 > Use setup_timer and mod_timer API instead of structure assignments. > > This is done using Coccinelle and semantic patch used > for this as follows: > > @@ > expression x,y,z,a,b; > @@ > > -init_timer (&x); > +setup_timer (&x, y, z); > +mod_timer (&a, b); > -x.function = y; > -x.data = z; > -x.expires = b; > -add_timer(&a); > > Signed-off-by: Himanshu Jha Applied to net-next, thanks.