Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031811AbdIZTFo (ORCPT ); Tue, 26 Sep 2017 15:05:44 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:38550 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967161AbdIZTFm (ORCPT ); Tue, 26 Sep 2017 15:05:42 -0400 X-Google-Smtp-Source: AOwi7QBo08kgwrmPNIefNsfncxMK3agALGAsgrLlRszQAtjX9CHGhtW98Y3zB3A4nT1kWMUOQZsrFA== Subject: Re: [PATCH net v2] net: dsa: mv88e6xxx: lock mutex when freeing IRQs To: Vivien Didelot , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Andrew Lunn References: <20170926185721.12187-1-vivien.didelot@savoirfairelinux.com> From: Florian Fainelli Message-ID: <1881d3da-0db8-c581-30de-a1dae20ceeaf@gmail.com> Date: Tue, 26 Sep 2017 12:05:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170926185721.12187-1-vivien.didelot@savoirfairelinux.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 455 Lines: 11 On 09/26/2017 11:57 AM, Vivien Didelot wrote: > mv88e6xxx_g2_irq_free locks the registers mutex, but not > mv88e6xxx_g1_irq_free, which results in a stack trace from > assert_reg_lock when unloading the mv88e6xxx module. Fix this. > > Fixes: 3460a5770ce9 ("net: dsa: mv88e6xxx: Mask g1 interrupts and free interrupt") > Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli -- Florian