Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S970377AbdIZUPk (ORCPT ); Tue, 26 Sep 2017 16:15:40 -0400 Received: from mail-it0-f50.google.com ([209.85.214.50]:53625 "EHLO mail-it0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967099AbdIZUPi (ORCPT ); Tue, 26 Sep 2017 16:15:38 -0400 X-Google-Smtp-Source: AOwi7QBj8QdFdsv/IP+jdGBkNRNTnG9M4iw31VF34xW/p1+nPDM5cilucKNAXS2XSlPx2EW1D1T6uQ== Date: Tue, 26 Sep 2017 14:15:35 -0600 From: Tycho Andersen To: Oleg Nesterov Cc: Kees Cook , Chris Salls , Andy Lutomirski , Will Drewry , "security@kernel.org" , LKML Subject: Re: [PATCH] seccomp: fix the usage of get/put_seccomp_filter() in seccomp_get_filter() Message-ID: <20170926201535.x4lkwck4h2a2itbt@smitten> References: <20170920125621.GA3599@redhat.com> <20170921105713.GA32672@redhat.com> <20170922152229.GA19152@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170922152229.GA19152@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 584 Lines: 18 Hi, On Fri, Sep 22, 2017 at 05:22:29PM +0200, Oleg Nesterov wrote: > On 09/21, Kees Cook wrote: > > Can you resend the two patches; I can send the backport to -stable manually... > > Not sure I understand... Do you mean this fix + untested "introduce get_nth_filter()" ? Just want to make sure this doesn't get lost in the shuffle. If I resend just Oleg's patch with the added __get_secomp_filter() instead of open coded refcount, will that work for you Kees? We can worry about the get_nth_filter implementation with the PTRACE_SECCOMP_GET_METADATA series later. Cheers, Tycho