Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032369AbdIZVtG (ORCPT ); Tue, 26 Sep 2017 17:49:06 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:56913 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032282AbdIZVtE (ORCPT ); Tue, 26 Sep 2017 17:49:04 -0400 Date: Tue, 26 Sep 2017 23:49:00 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 1/5] net: dsa: return -ENODEV is there is no slave PHY Message-ID: <20170926214900.GJ3325@lunn.ch> References: <20170926211535.21273-1-vivien.didelot@savoirfairelinux.com> <20170926211535.21273-2-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170926211535.21273-2-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 311 Lines: 9 On Tue, Sep 26, 2017 at 05:15:31PM -0400, Vivien Didelot wrote: > Instead of returning -EOPNOTSUPP when a slave device has no PHY, > directly return -ENODEV as ethtool and phylib do. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Andrew