Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032496AbdIZV74 (ORCPT ); Tue, 26 Sep 2017 17:59:56 -0400 Received: from mail-qt0-f195.google.com ([209.85.216.195]:38182 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031089AbdIZV7x (ORCPT ); Tue, 26 Sep 2017 17:59:53 -0400 X-Google-Smtp-Source: AOwi7QCgdAnB6/dbjuUbG6FN6JrpdAhFCY8O9Sp4atf5OKveVH/IFh8xoQU9SY30/n9x95cDXGtZew== Subject: Re: [PATCH net-next 1/5] net: dsa: return -ENODEV is there is no slave PHY To: Vivien Didelot , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Andrew Lunn References: <20170926211535.21273-1-vivien.didelot@savoirfairelinux.com> <20170926211535.21273-2-vivien.didelot@savoirfairelinux.com> From: Florian Fainelli Message-ID: <9c30119d-89b0-468f-926a-e831823a01a6@gmail.com> Date: Tue, 26 Sep 2017 14:59:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170926211535.21273-2-vivien.didelot@savoirfairelinux.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 303 Lines: 9 On 09/26/2017 02:15 PM, Vivien Didelot wrote: > Instead of returning -EOPNOTSUPP when a slave device has no PHY, > directly return -ENODEV as ethtool and phylib do. > > Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli -- Florian