Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032656AbdIZWqT (ORCPT ); Tue, 26 Sep 2017 18:46:19 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:57256 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031322AbdIZWoS (ORCPT ); Tue, 26 Sep 2017 18:44:18 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 26 Sep 2017 15:44:16 -0700 From: Subhash Jadavani To: Vivek Gautam Cc: kishon@ti.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, devicetree@vger.kernel.org, jejb@linux.vnet.ibm.com, vinholikatti@gmail.com Subject: Re: [PATCH 4/5] scsi/ufs: qcom: Set phy mode based on the controllers HS MODE In-Reply-To: <1501829332-5183-5-git-send-email-vivek.gautam@codeaurora.org> References: <1501829332-5183-1-git-send-email-vivek.gautam@codeaurora.org> <1501829332-5183-5-git-send-email-vivek.gautam@codeaurora.org> Message-ID: <99fc698fc93a05fc227d24a9ae15f183@codeaurora.org> User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1130 Lines: 32 On 2017-08-03 23:48, Vivek Gautam wrote: > Set the phy mode based on the UFS HS PA mode. This lets the > controller let phy know the mode in which the PHY Adapter is > running and set the phy rates accordingly. > > Signed-off-by: Vivek Gautam > --- > drivers/scsi/ufs/ufs-qcom.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c > index c87d770b519a..44c21d5818ee 100644 > --- a/drivers/scsi/ufs/ufs-qcom.c > +++ b/drivers/scsi/ufs/ufs-qcom.c > @@ -273,6 +273,9 @@ static int ufs_qcom_power_up_sequence(struct > ufs_hba *hba) > bool is_rate_B = (UFS_QCOM_LIMIT_HS_RATE == PA_HS_MODE_B) > ? true : false; > > + if (is_rate_B) > + phy_set_mode(phy, PHY_MODE_UFS_HS_B); > + > /* Assert PHY reset and apply PHY calibration values */ > ufs_qcom_assert_reset(hba); > /* provide 1ms delay to let the reset pulse propagate */ Looks good to me. Reviewed-by: Subhash Jadavani -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project