Date: Wed, 27 Sep 2017 03:49:18 +0300
From: Yury Norov <ynorov@caviumnetworks.com>
To: Andrew Morton <akpm@linux-foundation.org>,
        Al Viro <viro@zeniv.linux.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IPC: fix put_compat_shm_info()
Message-ID: <20170927004918.j5tgulqial4f67zh@yury-thinkpad>
References: <20170927003254.17604-1-ynorov@caviumnetworks.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170927003254.17604-1-ynorov@caviumnetworks.com>
User-Agent: NeoMutt/20170113 (1.7.2)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2017 00:49:32.8624 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR0701MB3833
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 989
Lines: 30

On Wed, Sep 27, 2017 at 03:32:54AM +0300, Yury Norov wrote:
> There's a typo in put_compat_shm_info() - the first argument
> of copy_to_user() is 'up' instead of 'uip'. And 'up' is
> occasionly a suitable variable name so the compiler doesn't
> complain.
> 
> Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>

Ah, I just pulled latest sources and found it already fixed.
Please forget.

> ---
>  ipc/shm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ipc/shm.c b/ipc/shm.c
> index 1e2b1692ba2c..badac463e2c8 100644
> --- a/ipc/shm.c
> +++ b/ipc/shm.c
> @@ -1154,7 +1154,7 @@ static int put_compat_shm_info(struct shm_info *ip,
>  	info.shm_swp = ip->shm_swp;
>  	info.swap_attempts = ip->swap_attempts;
>  	info.swap_successes = ip->swap_successes;
> -	return copy_to_user(up, &info, sizeof(info));
> +	return copy_to_user(uip, &info, sizeof(info));
>  }
>  
>  static int copy_compat_shmid_to_user(void __user *buf, struct shmid64_ds *in,
> -- 
> 2.11.0