Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032968AbdI0BO5 (ORCPT ); Tue, 26 Sep 2017 21:14:57 -0400 Received: from mailgw02.mediatek.com ([218.249.47.111]:40745 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S965519AbdI0BOy (ORCPT ); Tue, 26 Sep 2017 21:14:54 -0400 X-UUID: e4b0e7b9398e4dd6a4ae9e0b8034c0a0-20170927 Message-ID: <1506474885.19851.5.camel@mhfsdcap03> Subject: Re: [PATCH 02/12] arm64: dts: mt8173: remove "mediatek,mt8135-mmc" from mmc nodes From: Chaotian Jing To: Ulf Hansson CC: Rob Herring , Mark Rutland , Matthias Brugger , Catalin Marinas , Will Deacon , yong mao , Linus Walleij , "Javier Martinez Canillas" , Heiner Kallweit , Phong LE , "linux-mmc@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , , "linux-kernel@vger.kernel.org" , srv_heupstream Date: Wed, 27 Sep 2017 09:14:45 +0800 In-Reply-To: References: <1505207272-16983-1-git-send-email-chaotian.jing@mediatek.com> <1505207272-16983-3-git-send-email-chaotian.jing@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3188 Lines: 74 On Wed, 2017-09-27 at 00:37 +0200, Ulf Hansson wrote: > On 12 September 2017 at 11:07, Chaotian Jing wrote: > > devicetree bindings has been updated to support multi-platforms, > > so that each platform has its owns compatible name. > > And, this compatible name may used in driver to distinguish with > > other platform. > > This does not seems to be DT backwards compatible. > > If the driver starts interpreting the "mt8135-mmc" differently, > wouldn't that lead to old DTBs to become broken? > > Kind regards > Uffe At patch 03/12, it shows that no difference between "mt8135-mmc" and "mt8173-mmc", and following changes will make difference between these two. but, the user should update DTS & driver together,then will do not have compatible issue. > > > > > Signed-off-by: Chaotian Jing > > --- > > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 12 ++++-------- > > 1 file changed, 4 insertions(+), 8 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > index b99a273..26396ef 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > @@ -682,8 +682,7 @@ > > }; > > > > mmc0: mmc@11230000 { > > - compatible = "mediatek,mt8173-mmc", > > - "mediatek,mt8135-mmc"; > > + compatible = "mediatek,mt8173-mmc"; > > reg = <0 0x11230000 0 0x1000>; > > interrupts = ; > > clocks = <&pericfg CLK_PERI_MSDC30_0>, > > @@ -693,8 +692,7 @@ > > }; > > > > mmc1: mmc@11240000 { > > - compatible = "mediatek,mt8173-mmc", > > - "mediatek,mt8135-mmc"; > > + compatible = "mediatek,mt8173-mmc"; > > reg = <0 0x11240000 0 0x1000>; > > interrupts = ; > > clocks = <&pericfg CLK_PERI_MSDC30_1>, > > @@ -704,8 +702,7 @@ > > }; > > > > mmc2: mmc@11250000 { > > - compatible = "mediatek,mt8173-mmc", > > - "mediatek,mt8135-mmc"; > > + compatible = "mediatek,mt8173-mmc"; > > reg = <0 0x11250000 0 0x1000>; > > interrupts = ; > > clocks = <&pericfg CLK_PERI_MSDC30_2>, > > @@ -715,8 +712,7 @@ > > }; > > > > mmc3: mmc@11260000 { > > - compatible = "mediatek,mt8173-mmc", > > - "mediatek,mt8135-mmc"; > > + compatible = "mediatek,mt8173-mmc"; > > reg = <0 0x11260000 0 0x1000>; > > interrupts = ; > > clocks = <&pericfg CLK_PERI_MSDC30_3>, > > -- > > 1.8.1.1.dirty > >