Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969903AbdI0Cwt (ORCPT ); Tue, 26 Sep 2017 22:52:49 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:46380 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965983AbdI0Cws (ORCPT ); Tue, 26 Sep 2017 22:52:48 -0400 Date: Tue, 26 Sep 2017 19:52:44 -0700 (PDT) Message-Id: <20170926.195244.506518182147628099.davem@davemloft.net> To: paul.burton@imgtec.com Cc: matt.redfearn@imgtec.com, netdev@vger.kernel.org, alexandre.torgue@st.com, peppe.cavallaro@st.com, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, james.hogan@imgtec.com Subject: Re: [PATCH] net: stmmac: Meet alignment requirements for DMA From: David Miller In-Reply-To: <1752163.uYYNevmZpH@np-p-burton> References: <71740323.RRBhnhefTi@np-p-burton> <20170926.133309.1916643567158187651.davem@davemloft.net> <1752163.uYYNevmZpH@np-p-burton> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 26 Sep 2017 19:52:47 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 651 Lines: 18 From: Paul Burton Date: Tue, 26 Sep 2017 14:30:33 -0700 > I'd suggest that at a minimum if you're unwilling to obey the API as > described in Documentation/DMA-API.txt then it would be beneficial > if you could propose a change to it such that it works for you, and > perhaps we can extend the API & its documentation to allow your > usage whilst also allowing us to catch broken uses. The networking driver code works fine as is. I also didn't write that ill-advised documentation in the DMA docs, nor the non-merged new MIPS assertion. So I'm trying to figure out on what basis I am required to do anything. Thank you.