Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753476AbdI0EGW (ORCPT ); Wed, 27 Sep 2017 00:06:22 -0400 Received: from mga07.intel.com ([134.134.136.100]:62928 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751486AbdI0EGV (ORCPT ); Wed, 27 Sep 2017 00:06:21 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,443,1500966000"; d="asc'?scan'208";a="1018859459" Date: Wed, 27 Sep 2017 11:59:53 +0800 From: "Du, Changbin" To: Andrew Morton Cc: changbin.du@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: update comments for struct page.mapping Message-ID: <20170927035953.GA13117@intel.com> References: <1506410057-22316-1-git-send-email-changbin.du@intel.com> <20170926163027.12836f5006745fcf6e59ad24@linux-foundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ReaqsoxgOBHFXBhH" Content-Disposition: inline In-Reply-To: <20170926163027.12836f5006745fcf6e59ad24@linux-foundation.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1719 Lines: 54 --ReaqsoxgOBHFXBhH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 26, 2017 at 04:30:27PM -0700, Andrew Morton wrote: > On Tue, 26 Sep 2017 15:14:17 +0800 changbin.du@intel.com wrote: >=20 > > From: Changbin Du > >=20 > > The struct page.mapping can NULL or points to one object of type > > address_space, anon_vma or KSM private structure. > >=20 > > ... > > > > --- a/include/linux/mm_types.h > > +++ b/include/linux/mm_types.h > > @@ -47,8 +47,8 @@ struct page { > > * inode address_space, or NULL. > > * If page mapped as anonymous > > * memory, low bit is set, and > > - * it points to anon_vma object: > > - * see PAGE_MAPPING_ANON below. > > + * it points to anon_vma object > > + * or KSM private structure. > > */ > > void *s_mem; /* slab first object */ > > atomic_t compound_mapcount; /* first tail page */ >=20 > Why did you remove the (useful) reference to PAGE_MAPPING_ANON? There are two flags now, let me add them back. thanks. --=20 Thanks, Changbin Du --ReaqsoxgOBHFXBhH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJZyyI5AAoJEAanuZwLnPNUTCoIALp0SHey1lvHWnyMM6cwz490 Sq2XmtA3/FGoM3He2LC7TxYfoiwwlqn14qylyVc9rtFxqEHtXVXPGpuE7cK0L+oW Lp++ymDYjZOI5ewPuh+j93BkQxyoz4qOeo/LzIbnRUBJ1aeFv6axVHQV0uK0zFZZ IeEDP2JkjICLDAswgYIcyJ9a75ISSD0mE+viC9CBVL4yWnC7Rs4QCN8GTeMl15Oa 3Qn4hWkQycErvOdB77IJZkh9UMy4ZbmJQSSBjiKQ0gWbmNYJGJTf4e5FHDGzxkWz fAxyHakN0fipQPswss3vTUTs29Y04M+tziF4wElnXcZz+ef1vw0SsY9RNASelqE= =jgbl -----END PGP SIGNATURE----- --ReaqsoxgOBHFXBhH--