Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751628AbdI0GZv (ORCPT ); Wed, 27 Sep 2017 02:25:51 -0400 Received: from smtp-proxy003.phy.lolipop.jp ([157.7.104.44]:39614 "EHLO smtp-proxy003.phy.lolipop.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750836AbdI0GZu (ORCPT ); Wed, 27 Sep 2017 02:25:50 -0400 Subject: Re: [PATCH] ALSA: line6: make snd_pcm_ops const To: Bhumika Goyal , julia.lawall@lip6.fr, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <1506493167-7694-1-git-send-email-bhumirks@gmail.com> From: Takashi Sakamoto Message-ID: <19468cba-08dd-59be-8254-ba3d34560f31@sakamocchi.jp> Date: Wed, 27 Sep 2017 15:25:48 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1506493167-7694-1-git-send-email-bhumirks@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2678 Lines: 75 On Sep 27 2017 15:19, Bhumika Goyal wrote: > Make these const as they are only passed to a const argument of the > function snd_pcm_set_ops in the file referencing them. Also, add const > to the declaration in the headers. > > Structures found using Coccinelle and changes done by hand. > > Signed-off-by: Bhumika Goyal > --- > sound/usb/line6/capture.c | 2 +- > sound/usb/line6/capture.h | 2 +- > sound/usb/line6/playback.c | 2 +- > sound/usb/line6/playback.h | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) This looks good to me. Reviewed-by: Takashi Sakamoto > diff --git a/sound/usb/line6/capture.c b/sound/usb/line6/capture.c > index 7c81256..947d616 100644 > --- a/sound/usb/line6/capture.c > +++ b/sound/usb/line6/capture.c > @@ -248,7 +248,7 @@ static int snd_line6_capture_close(struct snd_pcm_substream *substream) > } > > /* capture operators */ > -struct snd_pcm_ops snd_line6_capture_ops = { > +const struct snd_pcm_ops snd_line6_capture_ops = { > .open = snd_line6_capture_open, > .close = snd_line6_capture_close, > .ioctl = snd_pcm_lib_ioctl, > diff --git a/sound/usb/line6/capture.h b/sound/usb/line6/capture.h > index 890b21b..b67ccc3 100644 > --- a/sound/usb/line6/capture.h > +++ b/sound/usb/line6/capture.h > @@ -17,7 +17,7 @@ > #include "driver.h" > #include "pcm.h" > > -extern struct snd_pcm_ops snd_line6_capture_ops; > +extern const struct snd_pcm_ops snd_line6_capture_ops; > > extern void line6_capture_copy(struct snd_line6_pcm *line6pcm, char *fbuf, > int fsize); > diff --git a/sound/usb/line6/playback.c b/sound/usb/line6/playback.c > index 812d181..819e9b2 100644 > --- a/sound/usb/line6/playback.c > +++ b/sound/usb/line6/playback.c > @@ -393,7 +393,7 @@ static int snd_line6_playback_close(struct snd_pcm_substream *substream) > } > > /* playback operators */ > -struct snd_pcm_ops snd_line6_playback_ops = { > +const struct snd_pcm_ops snd_line6_playback_ops = { > .open = snd_line6_playback_open, > .close = snd_line6_playback_close, > .ioctl = snd_pcm_lib_ioctl, > diff --git a/sound/usb/line6/playback.h b/sound/usb/line6/playback.h > index 51fce29..d8d3b8a 100644 > --- a/sound/usb/line6/playback.h > +++ b/sound/usb/line6/playback.h > @@ -27,7 +27,7 @@ > */ > #define USE_CLEAR_BUFFER_WORKAROUND 1 > > -extern struct snd_pcm_ops snd_line6_playback_ops; > +extern const struct snd_pcm_ops snd_line6_playback_ops; > > extern int line6_create_audio_out_urbs(struct snd_line6_pcm *line6pcm); > extern int line6_submit_audio_out_all_urbs(struct snd_line6_pcm *line6pcm); Thanks Takashi Sakamoto