Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752716AbdI0J1O (ORCPT ); Wed, 27 Sep 2017 05:27:14 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:33764 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752114AbdI0J1K (ORCPT ); Wed, 27 Sep 2017 05:27:10 -0400 X-AuditID: b6c32a37-c8dff70000001076-65-59cb6eeb99ac MIME-version: 1.0 Content-type: text/plain; charset="utf-8" Subject: Re: [PATCH 3/3] clk/mmp: Adjust 12 checks for null pointers To: SF Markus Elfring Cc: linux-clk@vger.kernel.org, Chao Xie , Michael Turquette , Stephen Boyd , LKML , kernel-janitors@vger.kernel.org From: Sylwester Nawrocki Message-id: <03eb0051-e03b-ee13-c68f-ee76a181a863@samsung.com> Date: Wed, 27 Sep 2017 11:26:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 In-reply-to: Content-language: en-GB Content-transfer-encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprAKsWRmVeSWpSXmKPExsWy7bCmge6bvNORBmv2MlpMOPeByeJ853Jm i623pC0+9txjtbi8aw6bxcVTrhY/znSzOLB7vL/Ryu5xua+XyWPywovMHk2n2lk9Pm+SC2CN 4rJJSc3JLEst0rdL4MqY+cKlYCJvxbGLc5gaGC9xdTFyckgImEgcvz+dvYuRi0NIYAejxLrH E9kgnO+MEo23PrDBVC1d+4QFIrGBUaL71V1WkASvgKDEj8n3WEBsZgFNiRdfJkEV3WeU+PLv OlhCWMBF4ml3L1MXIweHiICpxJ8TISA1zAK3GCW2bX3ADlLDJmAo0Xu0jxFiqJ3EtwnnWEHq WQRUJd5354KERQUiJLZ9nwF2EKeAp8Th+xsYIfaKSxy7fxPKlpc4eOU52A0SAmfYJO713IT6 wEXi2buLTBC2sMSr41vYQeZLCEhLXDpqC1HfzyhxYk0zI4Qzg1HiTvsEqAZricPHL7JCbOCT ePe1hxWimVeio00IosRDovH6eaiwo8TycxGQcLjNKDG7exHzBEa5WUjhNQspvGYh+WEWkh8W MLKsYhRLLSjOTU8tNiww1itOzC0uzUvXS87P3cQITida5jsYN5zzOcQowMGoxMPLEHIqUog1 say4MvcQowQHs5IIr23u6Ugh3pTEyqrUovz4otKc1OJDjNIcLErivGLrr0UICaQnlqRmp6YW pBbBZJk4OKUaGFNvqjK+nvLJKtTaNCmrs0XI/dPbthXHj/SKHH7kZmy3VTv+32u3ntuG8TOl ma9qfY49yaH/q9VRbHF31uQ3Ac8mbl6aYMnmYr9yB7OcQ02MaOfSxmULDYQO7DzAvPW9nOub ArP056f45T7esGxc6GS4iC8m217mbFZUl6l19+/uTcZ1ZvxblFiKMxINtZiLihMBRNEFOSMD AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGLMWRmVeSWpSXmKPExsVy+t9jQd3XeacjDc72qFhMOPeByeJ853Jm i623pC0+9txjtbi8aw6bxcVTrhY/znSzOLB7vL/Ryu5xua+XyWPywovMHk2n2lk9Pm+SC2CN 4rJJSc3JLEst0rdL4MqY+cKlYCJvxbGLc5gaGC9xdTFyckgImEgsXfuEBcQWEljHKLFgtyKI zSsgKPFj8j2gOAcHs4C6xJQpuV2MXEAlDxklbvTdYgapERZwkXja3csEUiMiYCrx50QISA2z wB1Gia/HTjBBNNxmlOg48IYNpIFNwFCi92gfI8QCO4lvE86xgjSzCKhKvO/OBQmLCkRI9L29 zA5icwp4Shy+vwGsnFlAXOLY/ZtQtrzEwSvPWSYwCsxCcuoshFNnIemYhaRjASPLKkbJ1ILi 3PTcYqMCw7zUcr3ixNzi0rx0veT83E2MwNDfdlirbwfj/SXxhxgFOBiVeHgjwk5FCrEmlhVX 5h5ilOBgVhLhtc09HSnEm5JYWZValB9fVJqTWnyIUZqDRUmc93besUghgfTEktTs1NSC1CKY LBMHp1QDY4eZ9ULZ/7NK7FbO3LqmjMdPO85m2dxgoVnLKmQyP739bxLP591lbbPiT+9TznPF dasPr2xXZNzxq1lNen/xTU6Pit//1DsaGi4zeM4s2DF5PsPVsyGhOQqKmrPnNR1s39L8JL/l qe7Lr/yzkmquciy+ZXhwL8M/t/1WL/adV6i4ecEx1Mc9Q4mlOCPRUIu5qDgRAIMU3Ut5AgAA X-CMS-MailID: 20170927092707epcas1p4265b0199ab366e08a950160cfdad9dd2 X-Msg-Generator: CA X-Sender-IP: 182.195.42.142 X-Local-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G+yCvOyEseyghOyekBtTZW5pb3IgU29mdHdhcmUgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-CMS-RootMailID: 20170927072816epcas3p1b533de74f5dcdee311045a24f6e60f50 X-RootMTR: 20170927072816epcas3p1b533de74f5dcdee311045a24f6e60f50 References: <051d7ba6-e3cc-8354-8315-93fe039dd2ce@users.sourceforge.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1631 Lines: 50 On 09/27/2017 09:27 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 27 Sep 2017 09:00:21 +0200 > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit Can you please fix your process and stop posting with above tags in the commit message? These 3 tags are already in the header of message you are sending. After your patches get applied we end up with a mess in commit messages as below. ------------------------------8<------------------------------- commit 0b08273c8ab7e688832120c4817b1adfdc56e231 Author: Markus Elfring Date: Thu Aug 17 21:35:16 2017 +0200 orangefs: Adjust three checks for null pointers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus fix affected source code places. Signed-off-by: Markus Elfring Signed-off-by: Mike Marshall ------------------------------8<------------------------------- Please see "DISCUSSION" paragraph of [1] for an explanation of what should be put in the message body. [1] https://git-scm.com/docs/git-format-patch -- Thanks, Sylwester > The script “checkpatch.pl” pointed information out like the following. > > Comparison to NULL could be written !… > > Thus fix the affected source code places. > > Signed-off-by: Markus Elfring