Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752696AbdI0KQg (ORCPT ); Wed, 27 Sep 2017 06:16:36 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:58132 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752083AbdI0KQe (ORCPT ); Wed, 27 Sep 2017 06:16:34 -0400 Date: Wed, 27 Sep 2017 12:16:22 +0200 From: Maxime Ripard To: Corentin Labbe Cc: robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org, linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, peppe.cavallaro@st.com, alexandre.torgue@st.com, andrew@lunn.ch, f.fainelli@gmail.com, frowand.list@gmail.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v6 06/11] ARM: dts: sunxi: h3/h5: represent the mdio switch used by sun8i-h3-emac Message-ID: <20170927101622.v7odmreccwh7ldg2@flea> References: <20170927073414.17361-1-clabbe.montjoie@gmail.com> <20170927073414.17361-7-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cn4zez4ijobb7pzg" Content-Disposition: inline In-Reply-To: <20170927073414.17361-7-clabbe.montjoie@gmail.com> User-Agent: NeoMutt/20170914 (1.9.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2877 Lines: 94 --cn4zez4ijobb7pzg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 27, 2017 at 07:34:09AM +0000, Corentin Labbe wrote: > Since dwmac-sun8i could use either an integrated PHY or an external PHY > (which could be at same MDIO address), we need to represent this selection > by a MDIO switch. >=20 > Signed-off-by: Corentin Labbe > --- > arch/arm/boot/dts/sunxi-h3-h5.dtsi | 31 +++++++++++++++++++++++++------ > 1 file changed, 25 insertions(+), 6 deletions(-) >=20 > diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi= -h3-h5.dtsi > index 3b7d953429a6..a8e9b8f378ba 100644 > --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi > +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi > @@ -422,14 +422,33 @@ > #size-cells =3D <0>; > status =3D "disabled"; > =20 > - mdio: mdio { > + mdio0: mdio { > #address-cells =3D <1>; > #size-cells =3D <0>; > - int_mii_phy: ethernet-phy@1 { > - compatible =3D "ethernet-phy-ieee802.3-c22"; > - reg =3D <1>; > - clocks =3D <&ccu CLK_BUS_EPHY>; > - resets =3D <&ccu RST_BUS_EPHY>; > + compatible =3D "snps,dwmac-mdio"; > + > + mdio-mux { > + compatible =3D "mdio-mux"; > + #address-cells =3D <1>; > + #size-cells =3D <0>; Newline > + /* Only one MDIO is usable at the time */ > + internal_mdio: mdio@1 { > + reg =3D <1>; > + #address-cells =3D <1>; > + #size-cells =3D <0>; Newline > + int_mii_phy: ethernet-phy@1 { > + compatible =3D "ethernet-phy-ieee802.3-c22"; > + reg =3D <1>; > + clocks =3D <&ccu CLK_BUS_EPHY>; > + resets =3D <&ccu RST_BUS_EPHY>; > + phy-is-integrated; > + }; > + }; Newline > + mdio: mdio@2 { This is quite confusing. Why not call the label external_mdio? Thanks --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --cn4zez4ijobb7pzg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZy3p2AAoJEBx+YmzsjxAgfXQQAJ6CiPvlQ/QdrRFceQIILDQ9 keqCNDVbwBLVrA7hQpjsPmsurmg7PRh3cHvHO2WE/rmzOoXk6BoAlMzCj6ZjGTjc wh9+rbZ7OXMkqU6ktMPFI7MPF84VLrQy09aASH4g4iMVKZYOn9gsp5+Roflg1k0z l56/Aous8o+xvlCx8vSZvNTSalKtyQ3ZNSX4lRRLeiLQGN/KgcjJH/DDbPSskvyE 1BHm6TIJL9z+coVI0YdxRKQa4KTi25ZxYPMWbniJh2uHDSciXAcJwyR3zGSwOm1m W3zlsq8MoULZ27uhwuoEcb59MBzjIq7jFenVpzdpKFm7fkjRKT+cvqxOXqVihuS3 sSoMEL+/FuJw0wuz1R9yfhS1JoBZhq31dJuuGIleBiprVHX1OJ8I/OiIR8Gyq+CR 2zM2MilQ62vWj3bNeZuyjHNG+R1U83KPCTMnDmd4DrizlwKd8iDgyt8RtUkDSE3L QepEry0x4t0CoZTo4puVijMVbpNdENwUM+YgIg/2vBd5frPIFpUIqnkI/06DdXGq lOkBgI8Zu5ekyPVwNihAf9+cKksCzd9j92WBxIronehnY8W4kGiM1Z2eyX6vnmi9 muzwUhGfQqE6aEDaEiNLt5MHHMUdc+T9d49GeodM/NjFoZnUM49ij149XmFfqANJ FhXpbtCRPTvns3/dXfav =cL7f -----END PGP SIGNATURE----- --cn4zez4ijobb7pzg--