Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752534AbdI0LfZ (ORCPT ); Wed, 27 Sep 2017 07:35:25 -0400 Received: from mx2.suse.de ([195.135.220.15]:56938 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751521AbdI0LfX (ORCPT ); Wed, 27 Sep 2017 07:35:23 -0400 Date: Wed, 27 Sep 2017 13:35:21 +0200 From: Petr Mladek To: Joe Lawrence Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Josh Poimboeuf , Jessica Yu , Jiri Kosina , Miroslav Benes , Chris J Arges Subject: Re: [PATCH v5 2/3] livepatch: move transition "complete" notice into klp_complete_transition() Message-ID: <20170927113521.GL21048@pathway.suse.cz> References: <1504191233-2642-1-git-send-email-joe.lawrence@redhat.com> <1504191233-2642-3-git-send-email-joe.lawrence@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504191233-2642-3-git-send-email-joe.lawrence@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 555 Lines: 16 On Thu 2017-08-31 10:53:52, Joe Lawrence wrote: > klp_complete_transition() performs a bit of housework before a > transition to KLP_PATCHED or KLP_UNPATCHED is actually completed > (including post-(un)patch callbacks). To be consistent, move the > transition "complete" kernel log notice out of > klp_try_complete_transition() and into klp_complete_transition(). > > Suggested-by: Josh Poimboeuf > Signed-off-by: Joe Lawrence Looks fine. Reviewed-by: Petr Mladek Best Regards, Petr