Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752507AbdI0MGS (ORCPT ); Wed, 27 Sep 2017 08:06:18 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:7447 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750854AbdI0MGQ (ORCPT ); Wed, 27 Sep 2017 08:06:16 -0400 Subject: Re: [PATCH v2] acpi: apei: Add SEI notification type support for ARMv8 To: Tyler Baicar , , , , , , , , , , , , , , , , , , , Stephen Boyd References: <1505373743-7780-1-git-send-email-gengdongjiu@huawei.com> <88a71a70-0704-6e47-de09-6f67b91967b6@codeaurora.org> CC: , From: gengdongjiu Message-ID: <8a622b5b-bcf1-3906-a4be-c3c86b0876fe@huawei.com> Date: Wed, 27 Sep 2017 20:05:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <88a71a70-0704-6e47-de09-6f67b91967b6@codeaurora.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.142.68.147] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.59CB941D.0190,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: d3804687231f71c61e74f37523b06b59 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1333 Lines: 41 Tyler, Stephen On 2017/9/27 3:23, Tyler Baicar wrote: >> Signed-off-by: Dongjiu Geng > Tested-by: Tyler Baicar > > Tested this functionality using SEA support. > > ++Stephen, > > Something to be aware of, this patch will conflict with https://lkml.org/lkml/2017/9/14/663 > It may make sense to just remove the conditions for the NMI configs as part of this patch or in a series with this patch to avoid merge conflicts. In your patch, you only remove ACPI_APEI_SEA for the ARCH_HAVE_NMI_SAFE_CMPXCHG, do you need to remove it for the HAVE_NMI? diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 3dcd7ec..8055997 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -19,6 +19,7 @@ config ARM64 select ARCH_HAS_STRICT_KERNEL_RWX select ARCH_HAS_STRICT_MODULE_RWX select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST + select ARCH_HAVE_NMI_SAFE_CMPXCHG if ACPI_APEI_SEA select ARCH_USE_CMPXCHG_LOCKREF select ARCH_SUPPORTS_ATOMIC_RMW select ARCH_SUPPORTS_NUMA_BALANCING @@ -92,6 +93,7 @@ config ARM64 select HAVE_IRQ_TIME_ACCOUNTING select HAVE_MEMBLOCK select HAVE_MEMBLOCK_NODE_MAP if NUMA + select HAVE_NMI if ACPI_APEI_SEA select HAVE_PATA_PLATFORM select HAVE_PERF_EVENTS select HAVE_PERF_REGS > > Thanks, > Tyler >> ---