Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752802AbdI0MYH (ORCPT ); Wed, 27 Sep 2017 08:24:07 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:36624 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752410AbdI0MYF (ORCPT ); Wed, 27 Sep 2017 08:24:05 -0400 X-Google-Smtp-Source: AOwi7QD2IOCaQsyxkbhsFzYUnThsN6P+NE8ATGxBQNqnq8PUqXihYcawIY3J7f3qP7znwmXxQRm0UQ== Date: Wed, 27 Sep 2017 14:24:01 +0200 From: Daniel Vetter To: Helge Deller Cc: linux-kernel@vger.kernel.org, Petr Mladek , David Airlie , intel-gfx@lists.freedesktop.org, Sergey Senozhatsky , Andrew Morton Subject: Re: [Intel-gfx] [PATCH 05/14] i915: Use %pS printk format for direct addresses Message-ID: <20170927122401.oqvdnaduzdk5tdwl@phenom.ffwll.local> Mail-Followup-To: Helge Deller , linux-kernel@vger.kernel.org, Petr Mladek , David Airlie , intel-gfx@lists.freedesktop.org, Sergey Senozhatsky , Andrew Morton References: <1504729681-3504-1-git-send-email-deller@gmx.de> <1504729681-3504-6-git-send-email-deller@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504729681-3504-6-git-send-email-deller@gmx.de> X-Operating-System: Linux phenom 4.12.0-1-amd64 User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1678 Lines: 46 On Wed, Sep 06, 2017 at 10:27:52PM +0200, Helge Deller wrote: > Use the %pS printk format for printing symbols from direct addresses. > This is important for the ia64, ppc64 and parisc64 architectures, while on > other architectures there is no difference between %pS and %pF. > Fix it for consistency across the kernel. i915.ko never runs on any of these, but if it helps with keeping things consistent, why not. Applied, thanks. -Daniel > > Signed-off-by: Helge Deller > Cc: Jani Nikula > Cc: David Airlie > Cc: intel-gfx@lists.freedesktop.org > --- > drivers/gpu/drm/i915/intel_breadcrumbs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_breadcrumbs.c b/drivers/gpu/drm/i915/intel_breadcrumbs.c > index 4e00e5c..29c62d4 100644 > --- a/drivers/gpu/drm/i915/intel_breadcrumbs.c > +++ b/drivers/gpu/drm/i915/intel_breadcrumbs.c > @@ -64,7 +64,7 @@ static unsigned long wait_timeout(void) > > static noinline void missed_breadcrumb(struct intel_engine_cs *engine) > { > - DRM_DEBUG_DRIVER("%s missed breadcrumb at %pF, irq posted? %s, current seqno=%x, last=%x\n", > + DRM_DEBUG_DRIVER("%s missed breadcrumb at %pS, irq posted? %s, current seqno=%x, last=%x\n", > engine->name, __builtin_return_address(0), > yesno(test_bit(ENGINE_IRQ_BREADCRUMB, > &engine->irq_posted)), > -- > 2.1.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch