Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753250AbdI0NLc (ORCPT ); Wed, 27 Sep 2017 09:11:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45386 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752408AbdI0NL2 (ORCPT ); Wed, 27 Sep 2017 09:11:28 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 48F353B750 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dledford@redhat.com Message-ID: <1506517886.82712.9.camel@redhat.com> Subject: Re: [PATCH] RDMA/cxgb3: remove redundant first assignement of sqp From: Doug Ledford To: Colin King , Steve Wise , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 27 Sep 2017 09:11:26 -0400 In-Reply-To: <20170911114231.22893-1-colin.king@canonical.com> References: <20170911114231.22893-1-colin.king@canonical.com> Organization: Red Hat, Inc. Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 27 Sep 2017 13:11:28 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 725 Lines: 20 On Mon, 2017-09-11 at 12:42 +0100, Colin King wrote: > From: Colin Ian King > > sqp is being initialised when it is being declared and then updated > a little later on making the first initialization redundant. Clean > this up by initializing ptr and sqp at their declaration. > > Cleans up warning: "warning: Value stored to 'sqp' during its > initialization is never read" > > Fixes: a58e58fafdff ("RDMA/cxgb3: Wrap the software send queue > pointer as needed on flush") > Signed-off-by: Colin Ian King Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD