Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753346AbdI0OTl (ORCPT ); Wed, 27 Sep 2017 10:19:41 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:58910 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752257AbdI0OTj (ORCPT ); Wed, 27 Sep 2017 10:19:39 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 12CC0602A9 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=tbaicar@codeaurora.org Subject: Re: [PATCH v2] acpi: apei: Add SEI notification type support for ARMv8 To: gengdongjiu , will.deacon@arm.com, zjzhang@codeaurora.org, catalin.marinas@arm.com, bp@suse.de, james.morse@arm.com, geliangtang@gmail.com, andriy.shevchenko@linux.intel.com, tony.luck@intel.com, austinwc@codeaurora.org, rjw@rjwysocki.net, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, john.garry@huawei.com, shiju.jose@huawei.com, zhengqiang10@huawei.com, wangxiongfeng2@huawei.com, Stephen Boyd Cc: huangshaoyu@huawei.com, wuquanming@huawei.com References: <1505373743-7780-1-git-send-email-gengdongjiu@huawei.com> <88a71a70-0704-6e47-de09-6f67b91967b6@codeaurora.org> <8a622b5b-bcf1-3906-a4be-c3c86b0876fe@huawei.com> From: Tyler Baicar Message-ID: <18fe5348-d339-f505-4b1b-c35501f40acc@codeaurora.org> Date: Wed, 27 Sep 2017 08:19:35 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <8a622b5b-bcf1-3906-a4be-c3c86b0876fe@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1560 Lines: 43 On 9/27/2017 6:05 AM, gengdongjiu wrote: > Tyler, Stephen > > On 2017/9/27 3:23, Tyler Baicar wrote: >>> Signed-off-by: Dongjiu Geng >> Tested-by: Tyler Baicar >> >> Tested this functionality using SEA support. >> >> ++Stephen, >> >> Something to be aware of, this patch will conflict with https://lkml.org/lkml/2017/9/14/663 >> It may make sense to just remove the conditions for the NMI configs as part of this patch or in a series with this patch to avoid merge conflicts. > In your patch, you only remove ACPI_APEI_SEA for the ARCH_HAVE_NMI_SAFE_CMPXCHG, do you need to remove it for the HAVE_NMI? From the latest comments it sounds like Stephen was going to remove it from both. https://lkml.org/lkml/2017/9/15/350 > > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 3dcd7ec..8055997 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -19,6 +19,7 @@ config ARM64 > select ARCH_HAS_STRICT_KERNEL_RWX > select ARCH_HAS_STRICT_MODULE_RWX > select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST > + select ARCH_HAVE_NMI_SAFE_CMPXCHG if ACPI_APEI_SEA > select ARCH_USE_CMPXCHG_LOCKREF > select ARCH_SUPPORTS_ATOMIC_RMW > select ARCH_SUPPORTS_NUMA_BALANCING > @@ -92,6 +93,7 @@ config ARM64 > select HAVE_IRQ_TIME_ACCOUNTING > select HAVE_MEMBLOCK > select HAVE_MEMBLOCK_NODE_MAP if NUMA > + select HAVE_NMI if ACPI_APEI_SEA > select HAVE_PATA_PLATFORM > select HAVE_PERF_EVENTS > select HAVE_PERF_REGS > >> Thanks, >> Tyler >>> ---