DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 248AAC058EA9
Message-ID: <1506522039.82712.26.camel@redhat.com>
Subject: Re: [PATCH] IB/mlx5:: pr_err() and mlx5_ib_dbg() strings should end
 with newlines
From: Doug Ledford <dledford@redhat.com>
To: Joe Perches <joe@perches.com>, Leon Romanovsky <leonro@mellanox.com>
Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>, matanb@mellanox.com,
        sean.hefty@intel.com, hal.rosenstock@gmail.com,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Wed, 27 Sep 2017 10:20:39 -0400
In-Reply-To: <1506453105.29089.14.camel@perches.com>
References: <7a5a195cd37db476a2ca007eddc0f28f3ade265b.1506407876.git.arvind.yadav.cs@gmail.com>
         <20170926083843.GB6816@mtr-leonro.local>
         <1506438337.29089.8.camel@perches.com>
         <20170926155006.GD6816@mtr-leonro.local>
         <1506453105.29089.14.camel@perches.com>
Organization: Red Hat, Inc.
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 658
Lines: 18

On Tue, 2017-09-26 at 12:11 -0700, Joe Perches wrote:
> On Tue, 2017-09-26 at 18:50 +0300, Leon Romanovsky wrote:
> > So how can I reproduce the different output before and after this
> > change?
> 
> Try lib/test_module.c with and without the newline
> on "Hello, World" on a quiescent system.

I agree here.  The newlines are still worthwhile as they remove any
unnecessary stalls in the printk output while the printk engine decides
whether or not you are going to do a KERN_CONT print next.

Thanks, applied.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD