Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932139AbdI0OcB (ORCPT ); Wed, 27 Sep 2017 10:32:01 -0400 Received: from mail-vk0-f44.google.com ([209.85.213.44]:55345 "EHLO mail-vk0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753158AbdI0Ob7 (ORCPT ); Wed, 27 Sep 2017 10:31:59 -0400 X-Google-Smtp-Source: AOwi7QARFKWsjxIXTsFcWZflAOpp16n1aJO7bwFF/pxrmugYb/KxkdEpVXfBeYt2NqGLQYtOfUF/B2ZGYglQWboO+HI= MIME-Version: 1.0 In-Reply-To: References: <20170927121649.90557-1-glider@google.com> <1506516168.6617.38.camel@edumazet-glaptop3.roam.corp.google.com> <1506516344.6617.39.camel@edumazet-glaptop3.roam.corp.google.com> From: Alexander Potapenko Date: Wed, 27 Sep 2017 16:31:57 +0200 Message-ID: Subject: Re: [PATCH v2] tun: bail out from tun_get_user() if the skb is empty To: Eric Dumazet Cc: Eric Dumazet , David Miller , Dmitriy Vyukov , syzkaller , Networking , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v8REW4jw024537 Content-Length: 1190 Lines: 33 On Wed, Sep 27, 2017 at 3:26 PM, 'Eric Dumazet' via syzkaller wrote: > On Wed, Sep 27, 2017 at 5:58 AM, Alexander Potapenko wrote: >> On Wed, Sep 27, 2017 at 2:45 PM, Eric Dumazet wrote: >>> On Wed, 2017-09-27 at 05:42 -0700, Eric Dumazet wrote: >>> >>>> Or something cleaner to avoid copy/paste and focus on proper >>>> skb->data[0] access and meaning. >> By the way I'm wondering if this is the only place where skb->data is >> being accessed. >> Isn't eth_type_trans() under IFF_TAP also touching it? Then we need to >> check the size earlier. > > It is already checked. Indeed, thanks. > -- > You received this message because you are subscribed to the Google Groups "syzkaller" group. > To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. -- Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Straße, 33 80636 München Geschäftsführer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg