Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752410AbdI0PKt (ORCPT ); Wed, 27 Sep 2017 11:10:49 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:58280 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752256AbdI0PKr (ORCPT ); Wed, 27 Sep 2017 11:10:47 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E670560708 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=nleeder@codeaurora.org Cc: nleeder@codeaurora.org, Mark Rutland , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mark Langsdorf , Mark Salter , Jon Masters , Timur Tabi , Mark Brown Subject: Re: [PATCH] perf: qcom_l2_pmu: add event names To: Will Deacon References: <1505417413-30757-1-git-send-email-nleeder@codeaurora.org> <20170925150829.GA30917@arm.com> From: "Leeder, Neil" Message-ID: <963de773-5501-029b-f9a2-d35a0864394f@codeaurora.org> Date: Wed, 27 Sep 2017 11:10:43 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170925150829.GA30917@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2731 Lines: 78 On 9/25/2017 11:08 AM, Will Deacon wrote: > On Thu, Sep 14, 2017 at 03:30:13PM -0400, Neil Leeder wrote: >> Add event names so that common events can be >> specified symbolically, for example: >> >> l2cache_0/total-reads/,l2cache_0/cycles/ >> >> Event names are displayed in 'perf list'. >> >> Signed-off-by: Neil Leeder >> --- >> drivers/perf/qcom_l2_pmu.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 54 insertions(+) >> >> diff --git a/drivers/perf/qcom_l2_pmu.c b/drivers/perf/qcom_l2_pmu.c >> index b242cce..4fdc848 100644 >> --- a/drivers/perf/qcom_l2_pmu.c >> +++ b/drivers/perf/qcom_l2_pmu.c >> @@ -92,6 +92,21 @@ >> >> #define reg_idx(reg, i) (((i) * IA_L2_REG_OFFSET) + reg##_BASE) >> >> +/* >> + * Events >> + */ >> +#define L2_EVENT_CYCLES 0xfe >> +#define L2_EVENT_DCACHE_OPS 0x400 >> +#define L2_EVENT_ICACHE_OPS 0x401 >> +#define L2_EVENT_TLBI 0x402 >> +#define L2_EVENT_BARRIERS 0x403 >> +#define L2_EVENT_TOTAL_READS 0x405 >> +#define L2_EVENT_TOTAL_WRITES 0x406 >> +#define L2_EVENT_TOTAL_REQUESTS 0x407 >> +#define L2_EVENT_LDREX 0x420 >> +#define L2_EVENT_STREX 0x421 >> +#define L2_EVENT_CLREX 0x422 >> + >> static DEFINE_RAW_SPINLOCK(l2_access_lock); >> >> /** >> @@ -700,9 +715,12 @@ static ssize_t l2_cache_pmu_cpumask_show(struct device *dev, >> /* CCG format for perf RAW codes. */ >> PMU_FORMAT_ATTR(l2_code, "config:4-11"); >> PMU_FORMAT_ATTR(l2_group, "config:0-3"); >> +PMU_FORMAT_ATTR(event, "config:0-11"); >> + >> static struct attribute *l2_cache_pmu_formats[] = { >> &format_attr_l2_code.attr, >> &format_attr_l2_group.attr, >> + &format_attr_event.attr, >> NULL, >> }; >> >> @@ -711,9 +729,45 @@ static ssize_t l2_cache_pmu_cpumask_show(struct device *dev, >> .attrs = l2_cache_pmu_formats, >> }; >> >> +static ssize_t l2cache_pmu_event_show(struct device *dev, >> + struct device_attribute *attr, char *page) >> +{ >> + struct perf_pmu_events_attr *pmu_attr; >> + >> + pmu_attr = container_of(attr, struct perf_pmu_events_attr, attr); >> + return sprintf(page, "event=0x%02llx\n", pmu_attr->id); > > Nit: do you want a 0x%03llx here? > > (I'm happy to take the patch either way, so just let me know) > > Will > Thanks Will. I'm leaning toward leaving it the way it is, if it's all the same to you. Neil -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.