DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EE0636E774
Date: Wed, 27 Sep 2017 17:15:42 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: Gargi Sharma <gs051095@gmail.com>
Cc: Rik van Riel <riel@surriel.com>, linux-kernel@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>, akpm@linux-foundation.org,
        mingo@kernel.org, pasha.tatashin@oracle.com, ktkhai@virtuozzo.com
Subject: Re: [PATCH v2 1/2] pid: Replace pid bitmap implementation with IDR
 API
Message-ID: <20170927151541.GA2429@redhat.com>
References: <cover.1506488388.git.gs051095@gmail.com>
 <e4bed733a4f8d7e8462a90a62f3b2fe15700c137.1506488388.git.gs051095@gmail.com>
 <1506517794.21121.93.camel@surriel.com>
 <20170927140658.GA28133@redhat.com>
 <CAOCi2DHSzSr-taNzwBk=6iT0g9=2KOnuK=qxOTtHKixxu+gdtQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAOCi2DHSzSr-taNzwBk=6iT0g9=2KOnuK=qxOTtHKixxu+gdtQ@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 524
Lines: 20

On 09/27, Gargi Sharma wrote:
>
> >
> > And make this patch correct ;)
> >
> > because currently it is wrong, zap_pid_ns_processes() won't kill the pid
> > returned by the first idr_get_next().
> Yes, I missed this. I can simply remove the idr_get_next() before the
> idr_for_each_continue and that will take care of it.

Yes, and also remove the while(pid) loop as Rik suggests, just do

	read_lock(&tasklist_lock);
	nr = 2;
	idr_for_each_entry_continue(..., nr) {
		kill pid_task()
	}
	read_unlock(&tasklist_lock);

Oleg.