Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752660AbdI0Pp3 (ORCPT ); Wed, 27 Sep 2017 11:45:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50546 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752188AbdI0Pp1 (ORCPT ); Wed, 27 Sep 2017 11:45:27 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7D0EC9D76B Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=joe.lawrence@redhat.com Subject: Re: [PATCH v5 3/3] livepatch: add transition notices To: Petr Mladek Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Josh Poimboeuf , Jessica Yu , Jiri Kosina , Miroslav Benes , Chris J Arges References: <1504191233-2642-1-git-send-email-joe.lawrence@redhat.com> <1504191233-2642-4-git-send-email-joe.lawrence@redhat.com> <20170927114908.GM21048@pathway.suse.cz> From: Joe Lawrence Organization: Red Hat Message-ID: Date: Wed, 27 Sep 2017 11:45:26 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20170927114908.GM21048@pathway.suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 27 Sep 2017 15:45:27 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1895 Lines: 57 On 09/27/2017 07:49 AM, Petr Mladek wrote: > On Thu 2017-08-31 10:53:53, Joe Lawrence wrote: >> Log a few kernel debug messages at the beginning of the following livepatch >> transition functions: >> >> klp_complete_transition() >> klp_cancel_transition() >> klp_init_transition() >> klp_reverse_transition() >> >> Also update the log notice message in klp_start_transition() for similar >> verbiage as the above messages. >> >> Suggested-by: Josh Poimboeuf >> Signed-off-by: Joe Lawrence >> --- >> kernel/livepatch/transition.c | 18 +++++++++++++++++- >> 1 file changed, 17 insertions(+), 1 deletion(-) >> >> diff --git a/kernel/livepatch/transition.c b/kernel/livepatch/transition.c >> index 53887f0bca10..3d44a3cf27be 100644 >> --- a/kernel/livepatch/transition.c >> +++ b/kernel/livepatch/transition.c >> @@ -82,6 +82,10 @@ static void klp_complete_transition(void) >> unsigned int cpu; >> bool immediate_func = false; >> >> + pr_debug("'%s': completing %s transition\n", >> + klp_transition_patch->mod->name, >> + klp_target_state == KLP_PATCHED ? "patching" : "unpatching"); >> + >> if (klp_target_state == KLP_UNPATCHED) { >> /* >> * All tasks have transitioned to KLP_UNPATCHED so we can now >> @@ -163,6 +167,9 @@ void klp_cancel_transition(void) >> if (WARN_ON_ONCE(klp_target_state != KLP_PATCHED)) >> return; >> >> + pr_debug("'%s': canceling transition, unpatching\n", > > This sentence is a bit confusing. It is related to the Mirek's concern > about that the following message would be "completing unpatching transition". > > What about using something like: > > pr_debug("'%s': canceling patching transition, going to unpatch\n", > > > Best Regards, > Petr Yeah, what I had was more of a comma splice for brevity... no problem adopting a clearer wording as you suggested. Thanks -- Joe