Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752198AbdI0Qjc (ORCPT ); Wed, 27 Sep 2017 12:39:32 -0400 Received: from mail-yw0-f179.google.com ([209.85.161.179]:43640 "EHLO mail-yw0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751798AbdI0Qj3 (ORCPT ); Wed, 27 Sep 2017 12:39:29 -0400 X-Google-Smtp-Source: AOwi7QASy68V3oN1phJ1S3AAxFwoPqs2YI21t/t3VZb1rwLBI0j8E2/dMDkI1tKS6a+xYiNlBO/t/2DT/jZrnps9L+E= MIME-Version: 1.0 In-Reply-To: <1506496556.28482.3.camel@suse.com> References: <20170926010925.114436-1-grundler@chromium.org> <1506496556.28482.3.camel@suse.com> From: Grant Grundler Date: Wed, 27 Sep 2017 09:39:28 -0700 X-Google-Sender-Auth: lArMNMxMKfJVgCqtMVTdBpxwIOQ Message-ID: Subject: Re: [PATCH V2] r8152: add Linksys USB3GIGV1 id To: Oliver Neukum Cc: Doug Anderson , Grant Grundler , "David S . Miller" , Greg Kroah-Hartman , Hayes Wang , LKML , linux-usb , netdev Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 907 Lines: 24 On Wed, Sep 27, 2017 at 12:15 AM, Oliver Neukum wrote: > Am Dienstag, den 26.09.2017, 08:19 -0700 schrieb Doug Anderson: >> >> I know that for at least some of the adapters in the CDC Ethernet >> blacklist it was claimed that the CDC Ethernet support in the adapter >> was kinda broken anyway so the blacklist made sense. ...but for the >> Linksys Gigabit adapter the CDC Ethernet driver seems to work OK, it's >> just not quite as full featured / efficient as the R8152 driver. >> >> Is that not a concern? I guess you could tell people in this >> situation that they simply need to enable the R8152 driver to get >> continued support for their Ethernet adapter? > > Hi, > > yes, it is a valid concern. An #ifdef will be needed. Good idea - I will post V3 shortly. I'm assuming you mean to add #ifdef CONFIG_USB_RTL8152 around the blacklist entry in cdc_ether driver. cheers, grant