Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751001AbdI0SzH (ORCPT ); Wed, 27 Sep 2017 14:55:07 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.47.9]:38033 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750704AbdI0SzG (ORCPT ); Wed, 27 Sep 2017 14:55:06 -0400 From: Eugeniy Paltsev To: "Eugeniy.Paltsev@synopsys.com" , "Vineet Gupta" , "linux-snps-arc@lists.infradead.org" CC: "linux-kernel@vger.kernel.org" , "Alexey Brodkin" , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH v3] ARC: [plat-hsdk]: Add reset controller node to manage ethernet reset Thread-Topic: [PATCH v3] ARC: [plat-hsdk]: Add reset controller node to manage ethernet reset Thread-Index: AQHTM8K8f3bzYdLvP0uRoird2kH3lqLI5lQAgAAU3AA= Date: Wed, 27 Sep 2017 18:55:01 +0000 Message-ID: <1506538500.30546.46.camel@synopsys.com> References: <20170922164911.1125-1-Eugeniy.Paltsev@synopsys.com> <85347975-edd9-7658-e2cd-7fe1436c77bb@synopsys.com> In-Reply-To: <85347975-edd9-7658-e2cd-7fe1436c77bb@synopsys.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.121.8.106] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v8RItDW5012144 Content-Length: 2457 Lines: 79 On Wed, 2017-09-27 at 10:40 -0700, Vineet Gupta wrote: > On 09/22/2017 09:49 AM, Eugeniy Paltsev wrote: > > DW ethernet controller on HSDK hangs sometimes after SW reset, so > > add reset node to make possible to reset DW ethernet controller HW. > > > > Signed-off-by: Eugeniy Paltsev > > --- > > Changes v2 -> v3: > >    * Remove v1 suffix as we finaly got rid of v1 suffix in reset > >      driver and docs. > >    * Rename reset node to "reset-controller" for consistency with > >      the other bindings. > > > > Changes v1 -> v2: > >    * Enable HSDK reset driver in hsdk_defconfig > > > >   arch/arc/boot/dts/hsdk.dts      | 9 +++++++++ > >   arch/arc/configs/hsdk_defconfig | 1 + > >   2 files changed, 10 insertions(+) > > > > diff --git a/arch/arc/boot/dts/hsdk.dts b/arch/arc/boot/dts/hsdk.dts > > index b922f3f..8adde1b 100644 > > --- a/arch/arc/boot/dts/hsdk.dts > > +++ b/arch/arc/boot/dts/hsdk.dts > > @@ -12,6 +12,7 @@ > >   /dts-v1/; > >    > >   #include > > +#include > >    > >   / { > >    model = "snps,hsdk"; > > @@ -102,6 +103,12 @@ > >    > >    ranges = <0x00000000 0xf0000000 0x10000000>; > >    > > + cgu_rst: reset-controller@8a0 { > > + compatible = "snps,hsdk-reset"; > > + #reset-cells = <1>; > > + reg = <0x8A0 0x4>, <0xFF0 0x4>; > > + }; > > + > >    core_clk: core-clk@0 { > >    compatible = "snps,hsdk-core-pll-clock"; > >    reg = <0x00 0x10>, <0x14B8 0x4>; > > @@ -158,6 +165,8 @@ > >    clocks = <&gmacclk>; > >    clock-names = "stmmaceth"; > >    phy-handle = <&phy0>; > > + resets = <&cgu_rst HSDK_ETH_RESET>; > > + reset-names = "stmmaceth"; > >    > >    mdio { > >    #address-cells = <1>; > > diff --git a/arch/arc/configs/hsdk_defconfig b/arch/arc/configs/hsdk_defconfig > > index 7b8f8fa..15f0f6b 100644 > > --- a/arch/arc/configs/hsdk_defconfig > > +++ b/arch/arc/configs/hsdk_defconfig > > @@ -63,6 +63,7 @@ CONFIG_MMC_SDHCI=y > >   CONFIG_MMC_SDHCI_PLTFM=y > >   CONFIG_MMC_DW=y > >   # CONFIG_IOMMU_SUPPORT is not set > > +CONFIG_RESET_HSDK=y > > Since we need this feature for our platform, better to just select it in Kconfig. > I can fix it up here if you agree ! Sure, I'm fine with it. > > -Vineet > > >   CONFIG_EXT3_FS=y > >   CONFIG_VFAT_FS=y > >   CONFIG_TMPFS=y > > --  Eugeniy Paltsev