Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751894AbdI0UXD (ORCPT ); Wed, 27 Sep 2017 16:23:03 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:50269 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751717AbdI0UXC (ORCPT ); Wed, 27 Sep 2017 16:23:02 -0400 X-Google-Smtp-Source: AOwi7QCmgGna649Dq0Sn3x8FkP9z8+wdTXFnDvsdlYRXnD8/4+3SJ+ydPSk7s4aNOi2ALhbd/6XVbg== Subject: Re: [PATCH 12/12] writeback: kill off ->range_cycle option To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Cc: hannes@cmpxchg.org, jack@suse.cz, torvalds@linux-foundation.org References: <1506543239-31470-1-git-send-email-axboe@kernel.dk> <1506543239-31470-13-git-send-email-axboe@kernel.dk> From: Jens Axboe Message-ID: Date: Wed, 27 Sep 2017 22:22:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1506543239-31470-13-git-send-email-axboe@kernel.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 613 Lines: 16 On 09/27/2017 10:13 PM, Jens Axboe wrote: > All types of writeback are now range cyclic. Kill off the member > from struct wb_writeback_work and struct writeback_control. > > Remove the various checks for whether or not this is range cyclic > writeback or not in the writeback code and file systems. > > For tracing, we leave the member there, and just always set it to 1. Disregard this patch, there are obviously places where we don't set range_cyclic at all and write out a subset of the dirty pages (or just one). Needs more looking into, for now just ignore this last patch in the series. -- Jens Axboe