Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751896AbdI0UfW (ORCPT ); Wed, 27 Sep 2017 16:35:22 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:37728 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751641AbdI0UfV (ORCPT ); Wed, 27 Sep 2017 16:35:21 -0400 X-Google-Smtp-Source: AOwi7QBZV/5qt9eUpZI9mzDSQt/+TBWYSZkFJMemy68zkrgmjxfU+DPAXO8KcB+6Q6CT5q3+Dzn6TA== Reply-To: minyard@acm.org Subject: Re: [PATCH] ipmi: pr_err() strings should end with newlines To: Arvind Yadav , luto@kernel.org Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org References: From: Corey Minyard Message-ID: Date: Wed, 27 Sep 2017 15:35:19 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1347 Lines: 43 On 09/25/2017 02:49 AM, Arvind Yadav wrote: > pr_err() messages should terminated with a new-line to avoid > other messages being concatenated onto the end. Thanks, it's queued for the next release. -corey > Signed-off-by: Arvind Yadav > --- > drivers/char/ipmi/ipmi_dmi.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/char/ipmi/ipmi_dmi.c b/drivers/char/ipmi/ipmi_dmi.c > index 2a84401..66dafcd 100644 > --- a/drivers/char/ipmi/ipmi_dmi.c > +++ b/drivers/char/ipmi/ipmi_dmi.c > @@ -71,13 +71,13 @@ static void __init dmi_add_platform_ipmi(unsigned long base_addr, > size = 2; > break; > default: > - pr_err("ipmi:dmi: Invalid IPMI type: %d", type); > + pr_err("ipmi:dmi: Invalid IPMI type: %d\n", type); > return; > } > > pdev = platform_device_alloc(name, ipmi_dmi_nr); > if (!pdev) { > - pr_err("ipmi:dmi: Error allocation IPMI platform device"); > + pr_err("ipmi:dmi: Error allocation IPMI platform device\n"); > return; > } > pdev->driver_override = override; > @@ -239,7 +239,7 @@ static void __init dmi_decode_ipmi(const struct dmi_header *dm) > offset = 16; > break; > default: > - pr_err("ipmi:dmi: Invalid offset: 0"); > + pr_err("ipmi:dmi: Invalid offset: 0\n"); > return; > } > }