Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752250AbdI0WAL (ORCPT <rfc822;w@1wt.eu>);
        Wed, 27 Sep 2017 18:00:11 -0400
Received: from mail-oi0-f68.google.com ([209.85.218.68]:35360 "EHLO
        mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752033AbdI0WAH (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 27 Sep 2017 18:00:07 -0400
X-Google-Smtp-Source: AOwi7QDHbQDNy2cJkoN9ggkhyvaNCiP3PAeHN+9ncJ9gEIWH6SH20h0QlKIy6TxEMastudCcPmwPdtLyO6wiTi2q/N8=
MIME-Version: 1.0
In-Reply-To: <1501584007-12433-1-git-send-email-sebastien.szymanski@armadeus.com>
References: <1501584007-12433-1-git-send-email-sebastien.szymanski@armadeus.com>
From: Fabio Estevam <festevam@gmail.com>
Date: Wed, 27 Sep 2017 19:00:06 -0300
Message-ID: <CAOMZO5B0U2O_aXmLBavmiU1G-ttxMg=p8+HMjUyQecH2_pZVqA@mail.gmail.com>
Subject: Re: [PATCH 1/1] clk: imx6: refine hdmi_isfr's parent to make HDMI
 work on i.MX6 SoCs w/o VPU
To: =?UTF-8?Q?S=C3=A9bastien_Szymanski?= 
        <sebastien.szymanski@armadeus.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
        Nicolas Colombain <nicolas.colombain@armadeus.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@codeaurora.org>,
        Julien Boibessot <julien.boibessot@armadeus.com>,
        Fabien Marteau <fabien.marteau@armadeus.com>,
        Sascha Hauer <kernel@pengutronix.de>,
        Fabio Estevam <fabio.estevam@nxp.com>, Shawn Guo <shawnguo@kernel.org>,
        linux-clk@vger.kernel.org,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v8RM0S4i024558
Content-Length: 1121
Lines: 27

On Tue, Aug 1, 2017 at 7:40 AM, Sébastien Szymanski
<sebastien.szymanski@armadeus.com> wrote:
> On i.MX6 SoCs without VPU (in my case MCIMX6D4AVT10AC), the hdmi driver
> fails to probe:
>
> [    2.540030] dwhdmi-imx 120000.hdmi: Unsupported HDMI controller
> (0000:00:00)
> [    2.548199] imx-drm display-subsystem: failed to bind 120000.hdmi
> (ops dw_hdmi_imx_ops): -19
> [    2.557403] imx-drm display-subsystem: master bind failed: -19
>
> That's because hdmi_isfr's parent, video_27m, is not correctly ungated.
> As explained in commit 5ccc248cc537 ("ARM: imx6q: clk: Add support for
> mipi_core_cfg clock as a shared clock gate"), video_27m is gated by
> CCM_CCGR3[CG8].
>
> On i.MX6 SoCs with VPU, the hdmi is working thanks to the
> CCM_CMEOR[mod_en_ov_vpu] bit which makes the video_27m ungated whatever
> is in CCM_CCGR3[CG8]. The issue can be reproduced by setting
> CCMEOR[mod_en_ov_vpu] to 0.
>
> Make the HDMI work in every case by setting hdmi_isfr's parent to
> mipi_core_cfg.
>
> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>