Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752392AbdI0XPI (ORCPT <rfc822;w@1wt.eu>);
        Wed, 27 Sep 2017 19:15:08 -0400
Received: from namei.org ([65.99.196.166]:50707 "EHLO namei.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752192AbdI0XPG (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 27 Sep 2017 19:15:06 -0400
Date: Thu, 28 Sep 2017 09:14:58 +1000 (AEST)
From: James Morris <jmorris@namei.org>
To: David Howells <dhowells@redhat.com>
cc: Eric Biggers <ebiggers@google.com>,
        "Jason A. Donenfeld" <Jason@zx2c4.com>,
        Michael Halcrow <mhalcrow@google.com>, keyrings@vger.kernel.org,
        linux-security-module@vger.kernel.org, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] KEYS: Fixes and crypto fixes
In-Reply-To: <28036.1506547164@warthog.procyon.org.uk>
Message-ID: <alpine.LRH.2.21.1709280912400.12069@namei.org>
References: <28036.1506547164@warthog.procyon.org.uk>
User-Agent: Alpine 2.21 (LRH 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 374
Lines: 15

On Wed, 27 Sep 2017, David Howells wrote:

>  (2) Fixing big_key to use safe crypto from Jason A. Donenfeld.
> 

I'm concerned about the lack of crypto review mentioned by Jason -- I 
wonder if we can get this rewrite any more review from crypto folk.

Also, are there any tests for this code?  If not, it would be good to make 
some.


-- 
James Morris
<jmorris@namei.org>