Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752576AbdI1C6r convert rfc822-to-8bit (ORCPT ); Wed, 27 Sep 2017 22:58:47 -0400 Received: from mga03.intel.com ([134.134.136.65]:44686 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752166AbdI1C6p (ORCPT ); Wed, 27 Sep 2017 22:58:45 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,448,1500966000"; d="scan'208";a="133053450" From: "Zheng, Lv" To: David Binderman , "Moore, Robert" , "Wysocki, Rafael J" , "lenb@kernel.org" , "linux-acpi@vger.kernel.org" , "devel@acpica.org" , "linux-kernel@vger.kernel.org" Subject: RE: linux-4.14-rc2/drivers/acpi/acpica/utmath.c: 2 * suspicious expression ? Thread-Topic: linux-4.14-rc2/drivers/acpi/acpica/utmath.c: 2 * suspicious expression ? Thread-Index: AQHTNgOm+35H5MYyaEiUXziUROMvIKLJnvxw Date: Thu, 28 Sep 2017 02:58:40 +0000 Message-ID: <1AE640813FDE7649BE1B193DEA596E886CF6DECD@SHSMSX101.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTQyMDM5NTctYTA4OS00Nzc4LThhYjYtYmI3YmJiMTM4NjEyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjhhQmdBcGZrendrQTg0ek96dEZcLzUzS0I2OUJzYWxBRjlGXC8zSUw5a2hKaz0ifQ== x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 889 Lines: 32 Hi, David Not a fancy way, but just a bit clearing. OK, style is changed here: https://github.com/acpica/acpica/pull/321 And bug is recorded here: https://bugs.acpica.org/show_bug.cgi?id=1422 Thanks for the report. Best regards Lv > From: David Binderman [mailto:dcb314@hotmail.com] > Subject: linux-4.14-rc2/drivers/acpi/acpica/utmath.c: 2 * suspicious expression ? > > Hello there, > > [linux-4.14-rc2/drivers/acpi/acpica/utmath.c:137] -> [linux-4.14-rc2/drivers/acpi/acpica/utmath.c:137]: > (style) Same expression on both sides of '^='. > [linux-4.14-rc2/drivers/acpi/acpica/utmath.c:174] -> [linux-4.14-rc2/drivers/acpi/acpica/utmath.c:174]: > (style) Same expression on both sides of '^='. > > operand_ovl.part.lo ^= operand_ovl.part.lo; > > Is this just a fancy way to zero the field or should something more clever > be happening ? > > Regards > > David Binderman >